Re: emacs 22.1 on hp-ux 11.11 core dumps when DISPLAY not set

Re: emacs 22.1 on hp-ux 11.11 core dumps when DISPLAY not set

[Richard Stallman]

    According to the internet, it was released in 2000 and is 3 or 4
    versions old.

That's good.  I think it is ok to desupport versions older than that.

So what about USG systems.  There is no problem with USG 5.4.
Are the USG 5.3 derivatives totally gone now?

However, given this information

    I looked for non-file scope statics in src/*.c. I think there are only
    a handful that aren't definitely in Windows, Mac, or VMS specific code:

    alloca.c      find_stack_direction
    fringe.c      init_fringe_bitmap
    gtkutil.c     menu_grab_callback, xg_separator_p
    image.c       our_memory_fill_input_buffer, gif_load
    xselect.c     x_reply_selection_request

I think we may as well fix the last four, unless that is hard.  Can
you fix them?

alloca.c is not an issue.  It checks for #define static and gives an
error.  It is also surely obsolete since 15 years ago; let's delete it
and its whole support mechanism in Emacs 23.

Re: emacs 22.1 on hp-ux 11.11 core dumps when DISPLAY not set

[Glenn Morris]

Richard Stallman wrote:

> So what about USG systems.  There is no problem with USG 5.4.
> Are the USG 5.3 derivatives totally gone now?

No idea, sorry.

>     fringe.c      init_fringe_bitmap
>     gtkutil.c     menu_grab_callback, xg_separator_p
>     image.c       our_memory_fill_input_buffer, gif_load
>     xselect.c     x_reply_selection_request
>
> I think we may as well fix the last four, unless that is hard.  Can
> you fix them?

I guess so. Do I just move all static variables to file scope,
irrespective of type? Does it matter whether they are explicitly
initialized, or if the values never change?

> alloca.c is not an issue.  It checks for #define static and gives an
> error.  It is also surely obsolete since 15 years ago; let's delete it
> and its whole support mechanism in Emacs 23.

Remove src/alloca.c from the trunk, you mean?

Re: emacs 22.1 on hp-ux 11.11 core dumps when DISPLAY not set

[Richard Stallman]

    I guess so. Do I just move all static variables to file scope,
    irrespective of type? Does it matter whether they are explicitly
    initialized, or if the values never change?

If the values never change, it is ok to have an initializer.
Variables with initializer may be put in pure space when Emacs is
dumped.

If the value can change, there must be no initializer.  So initialize
the variable in init_FILENAME or some such function that is called at
a suitable time.

It is a good idea to rename the variable
to a name that relates to the function that uses it.
Don't keep a short name like `cnt'.

Re: emacs 22.1 on hp-ux 11.11 core dumps when DISPLAY not set

[Richard Stallman]

    > alloca.c is not an issue.  It checks for #define static and gives an
    > error.  It is also surely obsolete since 15 years ago; let's delete it
    > and its whole support mechanism in Emacs 23.

    Remove src/alloca.c from the trunk, you mean?

Delete that file, and everything in Makefile.in and configure and m/
and s/ files that supports using it.

Re: emacs 22.1 on hp-ux 11.11 core dumps when DISPLAY not set

[Glenn Morris]

Richard Stallman wrote:

> If the values never change, it is ok to have an initializer.
> Variables with initializer may be put in pure space when Emacs is
> dumped.

I really meant: if they are explicitly initialized and never change,
is there any need to move them to file scope? In that case, they don't
actually have to _be_ static, AFAICS, so it's no problem if the HPUX
stuff defines "static" as a no-op.

Re: emacs 22.1 on hp-ux 11.11 core dumps when DISPLAY not set

[Richard Stallman]

    I really meant: if they are explicitly initialized and never change,
    is there any need to move them to file scope? In that case, they don't
    actually have to _be_ static, AFAICS, so it's no problem if the HPUX
    stuff defines "static" as a no-op.

If they don't need to be static, it is ok to delete `static'.
But please don't leave them file-scope static.
That is asking for confusion.

Re: emacs 22.1 on hp-ux 11.11 core dumps when DISPLAY not set

[Glenn Morris]

Richard Stallman wrote:

>     I really meant: if they are explicitly initialized and never change,
>     is there any need to move them to file scope? In that case, they don't
>     actually have to _be_ static, AFAICS, so it's no problem if the HPUX
>     stuff defines "static" as a no-op.
>
> If they don't need to be static, it is ok to delete `static'.
> But please don't leave them file-scope static.

I'm confused. Did you mean to say "function-scope" there?

Re: emacs 22.1 on hp-ux 11.11 core dumps when DISPLAY not set

[Glenn Morris]

Richard Stallman wrote:

>     Remove src/alloca.c from the trunk, you mean?
>
> Delete that file, and everything in Makefile.in and configure and m/
> and s/ files that supports using it.

Done.

Re: emacs 22.1 on hp-ux 11.11 core dumps when DISPLAY not set

[Richard Stallman]

    > If they don't need to be static, it is ok to delete `static'.
    > But please don't leave them file-scope static.

    I'm confused. Did you mean to say "function-scope" there?

Yes, I did.  Sorry.

Re: emacs 22.1 on hp-ux 11.11 core dumps when DISPLAY not set

[Glenn Morris]

Of the static uses I identified, five remain. I don't understand why
any of them need to be static, and I'm reluctant to change things I
don't understand. Which is better: leave them in function scope and
delete the `static', or move them to file scope?


fringe.c (init_fringe_bitmap) <swap_nibble>
gtkutil.c (xg_separator_p) <separator_names>
image.c  (our_memory_fill_input_buffer) <buffer>
         (gif_load) <interlace_start, interlace_increment>

Re: emacs 22.1 on hp-ux 11.11 core dumps when DISPLAY not set

[Jan Djärv]

Glenn Morris skrev:
> Of the static uses I identified, five remain. I don't understand why
> any of them need to be static, and I'm reluctant to change things I
> don't understand. Which is better: leave them in function scope and
> delete the `static', or move them to file scope?
> 

Move them to file scope.

On bug-gnu-emacs it was suggested in "emacs-22.1 with GTK problems (with 
patches)" that this in s/hpux.h:

/* USG systems tend to put everything declared static
    into the initialized data area, which becomes pure after dumping Emacs.
    Foil this.  Emacs carefully avoids static vars inside functions.  */

#define static

be removed, as it seems to interfere with threading.  How does that relate to 
the work you are doing?

	Jan D.

> 
> fringe.c (init_fringe_bitmap) <swap_nibble>
> gtkutil.c (xg_separator_p) <separator_names>
> image.c  (our_memory_fill_input_buffer) <buffer>
>          (gif_load) <interlace_start, interlace_increment>
> 

Re: emacs 22.1 on hp-ux 11.11 core dumps when DISPLAY not set

[Glenn Morris]

Jan Djärv wrote:

> Move them to file scope.

Will do, thanks.

> On bug-gnu-emacs it was suggested in "emacs-22.1 with GTK problems (with 
> patches)" that this in s/hpux.h:
[...]
> #define static
>
> be removed, as it seems to interfere with threading.

I already removed this in the trunk, as this thread seems to show it
is not needed in recent versions of hpux.h. I left it alone in the
release branch, but if it is actively causing problems, it should
probably be removed there too.

Re: emacs 22.1 on hp-ux 11.11 core dumps when DISPLAY not set

[Richard Stallman]

    I already removed this in the trunk, as this thread seems to show it
    is not needed in recent versions of hpux.h. I left it alone in the
    release branch, but if it is actively causing problems, it should
    probably be removed there too.

Please do remove that #define from hpux.h in Emacs 22.

Re: emacs 22.1 on hp-ux 11.11 core dumps when DISPLAY not set

[Richard Stallman]

    fringe.c (init_fringe_bitmap) <swap_nibble>

That should be file-scope.

    image.c  (our_memory_fill_input_buffer) <buffer>

That should be file-scope.

	     (gif_load) <interlace_start, interlace_increment>

They should be file-scope.

I did not check the gtk file.

Re: emacs 22.1 on hp-ux 11.11 core dumps when DISPLAY not set

[Glenn Morris]

Richard Stallman wrote:

> Please do remove that #define from hpux.h in Emacs 22.

Done. I believe this issue is now dealt with.