From: Richard Stallman <rms@gnu.org>
To: emacs-devel@gnu.org
Subject: [pixel@mandriva.com: segfault on buggy .gif + patch to fix it]
Date: Fri, 07 Sep 2007 02:31:28 -0400 [thread overview]
Message-ID: <E1ITXNI-00034e-SY@fencepost.gnu.org> (raw)
Would someone please check this patch, and either install
it and ack or expain why it is wrong?
------- Start of forwarded message -------
X-Spam-Status: No, score=0.0 required=5.0 tests=UNPARSEABLE_RELAY
autolearn=failed version=3.1.0
To: bug-gnu-emacs@gnu.org
From: Pixel <pixel@mandriva.com>
Date: Thu, 06 Sep 2007 16:00:09 +0200
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Subject: segfault on buggy .gif + patch to fix it
- --=-=-=
download http://people.mandriva.com/~prigaux/content.gif
(file not attached here for gnus users out there...)
then do "emacs content.gif" in X mode, it will segfault.
here is a simple patch to fix the issue:
- --=-=-=
Content-Type: text/x-patch
Content-Disposition: inline;
filename=emacs-snapshot-fix-segfault-loading-wrong-gif.patch
Index: src/image.c
===================================================================
RCS file: /sources/emacs/emacs/src/image.c,v
retrieving revision 1.85
diff -u -r1.85 image.c
- --- src/image.c 30 Aug 2007 05:05:58 -0000 1.85
+++ src/image.c 6 Sep 2007 13:56:19 -0000
@@ -7886,7 +7886,8 @@
init_color_table ();
bzero (pixel_colors, sizeof pixel_colors);
- - for (i = 0; i < gif_color_map->ColorCount; ++i)
+ if (gif_color_map)
+ for (i = 0; i < gif_color_map->ColorCount; ++i)
{
int r = gif_color_map->Colors[i].Red << 8;
int g = gif_color_map->Colors[i].Green << 8;
- --=-=-=
reproduced on:
GNU Emacs 22.1.1 (i486-pc-linux-gnu, X toolkit, Xaw3d scroll bars) of 2007-08-22 on raven, modified by Debian
GNU Emacs 22.1.1 (i386-mandrake-linux-gnu, X toolkit, Xaw3d scroll bars) of 2007-09-06 on n4.mandriva.com, modified by Mandriva
GNU Emacs 23.0.50.3 (i686-pc-linux-gnu, GTK+ Version 2.11.6, multi-tty) of 2007-09-06 on n4.mandriva.com
the buggy gif comes from a MMS by SFR (a french mobile phone operator)
- --=-=-=
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
bug-gnu-emacs mailing list
bug-gnu-emacs@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-gnu-emacs
- --=-=-=--
------- End of forwarded message -------
next reply other threads:[~2007-09-07 6:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-07 6:31 Richard Stallman [this message]
2007-09-07 7:11 ` [pixel@mandriva.com: segfault on buggy .gif + patch to fix it] Thien-Thi Nguyen
2007-09-07 7:39 ` Nick Roberts
2007-09-07 10:37 ` Thien-Thi Nguyen
2007-09-07 12:42 ` Jason Rumney
2007-09-07 15:31 ` Davis Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1ITXNI-00034e-SY@fencepost.gnu.org \
--to=rms@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).