From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Richard Stallman <rms@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [cezar@mixandgo.ro: skeleton bug]
Date: Mon, 03 Sep 2007 14:25:52 -0400
Message-ID: <E1ISGcS-00065X-P9@fencepost.gnu.org>
References: <E1IRriB-0006Rk-ES@fencepost.gnu.org>
	<E1IS1j3-00052e-2S@etlken.m17n.org>
Reply-To: rms@gnu.org
NNTP-Posting-Host: lo.gmane.org
Content-Type: text/plain; charset=ISO-8859-15
X-Trace: sea.gmane.org 1188844126 27230 80.91.229.12 (3 Sep 2007 18:28:46 GMT)
X-Complaints-To: usenet@sea.gmane.org
NNTP-Posting-Date: Mon, 3 Sep 2007 18:28:46 +0000 (UTC)
Cc: cezar@mixandgo.ro, emacs-devel@gnu.org
To: Kenichi Handa <handa@m17n.org>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Sep 03 20:28:44 2007
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([199.232.76.165])
	by lo.gmane.org with esmtp (Exim 4.50)
	id 1ISGf8-0005x6-Ha
	for ged-emacs-devel@m.gmane.org; Mon, 03 Sep 2007 20:28:38 +0200
Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43)
	id 1ISGf7-0001S3-55
	for ged-emacs-devel@m.gmane.org; Mon, 03 Sep 2007 14:28:37 -0400
Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1ISGci-0007q6-Tl
	for emacs-devel@gnu.org; Mon, 03 Sep 2007 14:26:08 -0400
Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1ISGci-0007p5-4H
	for emacs-devel@gnu.org; Mon, 03 Sep 2007 14:26:08 -0400
Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1ISGch-0007ow-Vz
	for emacs-devel@gnu.org; Mon, 03 Sep 2007 14:26:08 -0400
Original-Received: from fencepost.gnu.org ([140.186.70.10])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <rms@gnu.org>) id 1ISGch-000062-M9
	for emacs-devel@gnu.org; Mon, 03 Sep 2007 14:26:07 -0400
Original-Received: from rms by fencepost.gnu.org with local (Exim 4.60)
	(envelope-from <rms@gnu.org>)
	id 1ISGcS-00065X-P9; Mon, 03 Sep 2007 14:25:52 -0400
In-reply-to: <E1IS1j3-00052e-2S@etlken.m17n.org> (message from Kenichi Handa
	on Mon, 03 Sep 2007 11:31:41 +0900)
X-Detected-Kernel: Linux 2.6, seldom 2.4 (older, 4)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:77667
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/77667>

    I found that this is because of the following incompatible
    change in emacs-unicode-2.

    Emacs-22: (char-or-string-p -1) => t
    Emacs-23: (char-or-string-p -1) => nil

    According to the function name, I think it should return nil
    on -1.

    Which do you think is better?

    (1) Revert the change of char-or-string-p.

    (2) Keep char-or-string-p as is in emacs-unicode-2,
	make a new function integer-or-string-p, and check all
	occurrences of char-or-string-p in *.el files.

I think we should keep the changed behavior of char-or-string-p,
which fits with its name, and check all 8 callers.