unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Richard Stallman <rms@gnu.org>
To: Kenichi Handa <handa@m17n.org>
Cc: cezar@mixandgo.ro, emacs-devel@gnu.org
Subject: Re: [cezar@mixandgo.ro: skeleton bug]
Date: Mon, 03 Sep 2007 14:25:52 -0400	[thread overview]
Message-ID: <E1ISGcS-00065X-P9@fencepost.gnu.org> (raw)
In-Reply-To: <E1IS1j3-00052e-2S@etlken.m17n.org> (message from Kenichi Handa on Mon, 03 Sep 2007 11:31:41 +0900)

    I found that this is because of the following incompatible
    change in emacs-unicode-2.

    Emacs-22: (char-or-string-p -1) => t
    Emacs-23: (char-or-string-p -1) => nil

    According to the function name, I think it should return nil
    on -1.

    Which do you think is better?

    (1) Revert the change of char-or-string-p.

    (2) Keep char-or-string-p as is in emacs-unicode-2,
	make a new function integer-or-string-p, and check all
	occurrences of char-or-string-p in *.el files.

I think we should keep the changed behavior of char-or-string-p,
which fits with its name, and check all 8 callers.

  reply	other threads:[~2007-09-03 18:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1IRriB-0006Rk-ES@fencepost.gnu.org>
2007-09-03  2:31 ` [cezar@mixandgo.ro: skeleton bug] Kenichi Handa
2007-09-03 18:25   ` Richard Stallman [this message]
2007-09-03 21:22     ` Stefan Monnier
2007-09-07  2:33       ` Kenichi Handa
2007-09-07  4:04         ` Stefan Monnier
2007-09-07 19:53         ` Richard Stallman
2007-08-25  4:07 Richard Stallman
2007-08-25 16:46 ` Chong Yidong
2007-08-26 14:56   ` Richard Stallman
2007-08-25 19:52 ` Glenn Morris
  -- strict thread matches above, loose matches on Subject: below --
2007-08-17 20:17 Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1ISGcS-00065X-P9@fencepost.gnu.org \
    --to=rms@gnu.org \
    --cc=cezar@mixandgo.ro \
    --cc=emacs-devel@gnu.org \
    --cc=handa@m17n.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).