[cezar@mixandgo.ro: skeleton bug]

[cezar@mixandgo.ro: skeleton bug]

[Richard Stallman]

Would someone please DTRT, then ack?

------- Start of forwarded message -------
X-Spam-Status: No, score=1.8 required=5.0 tests=NO_REAL_NAME,
	RCVD_IN_SORBS_WEB,SPF_HELO_PASS,SPF_PASS,UNPARSEABLE_RELAY 
	autolearn=no version=3.1.0
To: bug-gnu-emacs@gnu.org
From: cezar@mixandgo.ro
Date: Fri, 17 Aug 2007 14:36:29 +0300
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: skeleton bug


Hello,

  I have created a small skeleton which should insert a html list in this form :

<ul>
  <li>
  </li>
</ul>

  The skeleton looks like this : 

(define-skeleton test-skeleton
  "This is a small doc for the skeleton."
  ""                                    ;no prompt
  > "<ul>"
  \n > "<li>"
  \n > _
  \n > -1 "</li>"
  \n > "</ul>"
  \n)

  but it does not work ! The error I get follows:

Debugger entered--Lisp error: (error "Lisp nesting exceeds `max-lisp-eval-depth'")
  skeleton-internal-1(-1 t nil)
  skeleton-internal-1(-1 t nil)
  [.. a lot more of these .. ]
  skeleton-internal-1(-1 t nil)
  skeleton-internal-1(-1 t nil)
  skeleton-internal-1(-1 nil nil)
  byte-code("=c2\b@=c3	#=87" [skeleton recursive skeleton-internal-1 nil] 4)
  skeleton-internal-list(("" > "<ul>" n > "<li>" n > _ n > -1 "</li>" n > "</ul>" n) nil)
  (let nil (skeleton-internal-list skeleton str))
  eval((let nil (skeleton-internal-list skeleton str)))
  skeleton-insert(("" > "<ul>" n > "<li>" n > _ n > -1 "</li>" n > "</ul>" n) nil nil)
  skeleton-proxy-new(("" > "<ul>" n > "<li>" n > _ n > -1 "</li>" n > "</ul>" n) nil nil)
  test-skeleton(nil nil)
  call-interactively(test-skeleton)
  execute-extended-command(nil)
  call-interactively(execute-extended-command)

In GNU Emacs 23.0.0.1 (i686-pc-linux-gnu, GTK+ Version 2.10.12)
 of 2007-06-12 on myhost
Windowing system distributor `The X.Org Foundation', version 11.0.70200000
configured using `configure  '--enable-font-backend' '--with-xft' '--with-freetype' '--with-gtk' '--with-prefix=/opt''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: C
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.utf8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Emacs-Lisp

Minor modes in effect:
  tooltip-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-compression-mode: t
  line-number-mode: t




_______________________________________________
bug-gnu-emacs mailing list
bug-gnu-emacs@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-gnu-emacs
------- End of forwarded message -------

[cezar@mixandgo.ro: skeleton bug]

[Richard Stallman]

[I sent this message a week ago but did not get a response.]

Would someone please DTRT, then ack?

------- Start of forwarded message -------
X-Spam-Status: No, score=1.8 required=5.0 tests=NO_REAL_NAME,
	RCVD_IN_SORBS_WEB,SPF_HELO_PASS,SPF_PASS,UNPARSEABLE_RELAY 
	autolearn=no version=3.1.0
To: bug-gnu-emacs@gnu.org
From: cezar@mixandgo.ro
Date: Fri, 17 Aug 2007 14:36:29 +0300
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: skeleton bug


Hello,

  I have created a small skeleton which should insert a html list in this form :

<ul>
  <li>
  </li>
</ul>

  The skeleton looks like this : 

(define-skeleton test-skeleton
  "This is a small doc for the skeleton."
  ""                                    ;no prompt
  > "<ul>"
  \n > "<li>"
  \n > _
  \n > -1 "</li>"
  \n > "</ul>"
  \n)

  but it does not work ! The error I get follows:

Debugger entered--Lisp error: (error "Lisp nesting exceeds `max-lisp-eval-depth'")
  skeleton-internal-1(-1 t nil)
  skeleton-internal-1(-1 t nil)
  [.. a lot more of these .. ]
  skeleton-internal-1(-1 t nil)
  skeleton-internal-1(-1 t nil)
  skeleton-internal-1(-1 nil nil)
  byte-code("=c2\b@=c3	#=87" [skeleton recursive skeleton-internal-1 nil] 4)
  skeleton-internal-list(("" > "<ul>" n > "<li>" n > _ n > -1 "</li>" n > "</ul>" n) nil)
  (let nil (skeleton-internal-list skeleton str))
  eval((let nil (skeleton-internal-list skeleton str)))
  skeleton-insert(("" > "<ul>" n > "<li>" n > _ n > -1 "</li>" n > "</ul>" n) nil nil)
  skeleton-proxy-new(("" > "<ul>" n > "<li>" n > _ n > -1 "</li>" n > "</ul>" n) nil nil)
  test-skeleton(nil nil)
  call-interactively(test-skeleton)
  execute-extended-command(nil)
  call-interactively(execute-extended-command)

In GNU Emacs 23.0.0.1 (i686-pc-linux-gnu, GTK+ Version 2.10.12)
 of 2007-06-12 on myhost
Windowing system distributor `The X.Org Foundation', version 11.0.70200000
configured using `configure  '--enable-font-backend' '--with-xft' '--with-freetype' '--with-gtk' '--with-prefix=/opt''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: C
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.utf8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Emacs-Lisp

Minor modes in effect:
  tooltip-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-compression-mode: t
  line-number-mode: t




_______________________________________________
bug-gnu-emacs mailing list
bug-gnu-emacs@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-gnu-emacs
------- End of forwarded message -------

Re: [cezar@mixandgo.ro: skeleton bug]

[Chong Yidong]

Richard Stallman <rms@gnu.org> writes:

>   I have created a small skeleton which should insert a html list in
>   this form ... The skeleton looks like this :
>
> (define-skeleton test-skeleton
>   "This is a small doc for the skeleton."
>   ""                                    ;no prompt
>   > "<ul>"
>   \n > "<li>"
>   \n > _
>   \n > -1 "</li>"
>   \n > "</ul>"
>   \n)
>
>   but it does not work ! The error I get follows:
>
> Debugger entered--Lisp error: (error "Lisp nesting exceeds `max-lisp-eval-depth'")
>   skeleton-internal-1(-1 t nil)
>   ....
>   call-interactively(test-skeleton)
>   execute-extended-command(nil)
>   call-interactively(execute-extended-command)
>
> In GNU Emacs 23.0.0.1 (i686-pc-linux-gnu, GTK+ Version 2.10.12)
>  of 2007-06-12 on myhost


I can't reproduce this on the Emacs 22 branch or trunk --- maybe it is
specific to the unicode-2 branch.

Re: [cezar@mixandgo.ro: skeleton bug]

[Glenn Morris]

Richard Stallman wrote:

> [I sent this message a week ago but did not get a response.]
>
> Would someone please DTRT, then ack?

I can't reproduce this in either Emacs 22 or cvs trunk. Note that this
report seems to be about unicode-2 branch (so was sent to the wrong
address).

> From: cezar@mixandgo.ro
> Subject: skeleton bug
> To: bug-gnu-emacs@gnu.org
> Date: Fri, 17 Aug 2007 14:36:29 +0300
[...]
> In GNU Emacs 23.0.0.1 (i686-pc-linux-gnu, GTK+ Version 2.10.12)

Re: [cezar@mixandgo.ro: skeleton bug]

[Richard Stallman]

    I can't reproduce this on the Emacs 22 branch or trunk --- maybe it is
    specific to the unicode-2 branch.

Thanks.  I asked Handa to work on it.

Re: [cezar@mixandgo.ro: skeleton bug]

[Kenichi Handa]

In article <E1IRriB-0006Rk-ES@fencepost.gnu.org>, Richard Stallman <rms@gnu.org> writes:

> ------- Start of forwarded message -------
> To: bug-gnu-emacs@gnu.org
> From: cezar@mixandgo.ro
> Date: Fri, 17 Aug 2007 14:36:29 +0300
> Subject: skeleton bug

[...]
>   The skeleton looks like this : 

> (define-skeleton test-skeleton
>   "This is a small doc for the skeleton."
>   ""                                    ;no prompt
> "<ul>"
>   \n > "<li>"
>   \n > _
>   \n > -1 "</li>"
>   \n > "</ul>"
>   \n)

>   but it does not work ! The error I get follows:

> Debugger entered--Lisp error: (error "Lisp nesting exceeds `max-lisp-eval-depth'")

I found that this is because of the following incompatible
change in emacs-unicode-2.

Emacs-22: (char-or-string-p -1) => t
Emacs-23: (char-or-string-p -1) => nil

According to the function name, I think it should return nil
on -1.

Which do you think is better?

(1) Revert the change of char-or-string-p.

(2) Keep char-or-string-p as is in emacs-unicode-2,
    make a new function integer-or-string-p, and check all
    occurrences of char-or-string-p in *.el files.

FYI, char-or-string-p is used only in 8 places.

---
Kenichi Handa
handa@m17n.org

Re: [cezar@mixandgo.ro: skeleton bug]

[Richard Stallman]

    I found that this is because of the following incompatible
    change in emacs-unicode-2.

    Emacs-22: (char-or-string-p -1) => t
    Emacs-23: (char-or-string-p -1) => nil

    According to the function name, I think it should return nil
    on -1.

    Which do you think is better?

    (1) Revert the change of char-or-string-p.

    (2) Keep char-or-string-p as is in emacs-unicode-2,
	make a new function integer-or-string-p, and check all
	occurrences of char-or-string-p in *.el files.

I think we should keep the changed behavior of char-or-string-p,
which fits with its name, and check all 8 callers.

Re: [cezar@mixandgo.ro: skeleton bug]

[Stefan Monnier]

>     I found that this is because of the following incompatible
>     change in emacs-unicode-2.

>     Emacs-22: (char-or-string-p -1) => t
>     Emacs-23: (char-or-string-p -1) => nil

>     According to the function name, I think it should return nil
>     on -1.

>     Which do you think is better?

>     (1) Revert the change of char-or-string-p.

>     (2) Keep char-or-string-p as is in emacs-unicode-2,
> 	make a new function integer-or-string-p, and check all
> 	occurrences of char-or-string-p in *.el files.

> I think we should keep the changed behavior of char-or-string-p,
> which fits with its name, and check all 8 callers.

Agreed,


        Stefan

Re: [cezar@mixandgo.ro: skeleton bug]

[Kenichi Handa]

In article <jwvbqcj78bg.fsf-monnier+emacs@gnu.org>, Stefan Monnier <monnier@iro.umontreal.ca> writes:

> >     I found that this is because of the following incompatible
> >     change in emacs-unicode-2.

> >     Emacs-22: (char-or-string-p -1) => t
> >     Emacs-23: (char-or-string-p -1) => nil

> >     According to the function name, I think it should return nil
> >     on -1.

> >     Which do you think is better?

> >     (1) Revert the change of char-or-string-p.

> >     (2) Keep char-or-string-p as is in emacs-unicode-2,
> > 	make a new function integer-or-string-p, and check all
> > 	occurrences of char-or-string-p in *.el files.

> > I think we should keep the changed behavior of char-or-string-p,
> > which fits with its name, and check all 8 callers.

> Agreed,

Ok.  It was only skeleton.el that has a problem, and I fixed
it.  I didn't create integer-or-string-p because it seems
that the function is not that useful.  In skeleton.el, I
simply used the combination of integerp and stringp.

---
Kenichi Handa
handa@m17n.org

Re: [cezar@mixandgo.ro: skeleton bug]

[Stefan Monnier]

>> > I think we should keep the changed behavior of char-or-string-p,
>> > which fits with its name, and check all 8 callers.

>> Agreed,

> Ok.  It was only skeleton.el that has a problem, and I fixed
> it.  I didn't create integer-or-string-p because it seems
> that the function is not that useful.  In skeleton.el, I
> simply used the combination of integerp and stringp.

Great, thank you,


        Stefan

Re: [cezar@mixandgo.ro: skeleton bug]

[Richard Stallman]

    Ok.  It was only skeleton.el that has a problem, and I fixed
    it.  I didn't create integer-or-string-p because it seems
    that the function is not that useful.  In skeleton.el, I
    simply used the combination of integerp and stringp.

That sounds right.  Thanks.