[OS X] Title bar icon

[OS X] Title bar icon

[Seiji Zenitani]

Hi,

When visiting a file, the Carbon (OS X) port displays a small proxy  
icon in the window title bar, like other OS X applications.

However, the proxy icon disappears when the cursor temporary visits  
the mini buffer (i.e. saving the buffer to another file by C-x C-w),  
often enough to attract the user's attention.  I don't think it is  
necessary to update the proxy icon in the case of the mini buffer,  
because the mini buffer usually receives the user's input or shows a  
message.  How about disabling the update_proxy_icon function in the  
mini buffer?  I use the following patch in order to modify the above  
behavior.

Seiji Zenitani
zenitani@mac.com

--- src/macfns.c.orig	2007-07-25 23:05:09.000000000 -0400
+++ src/macfns.c	2007-07-28 22:34:13.000000000 -0400
@@ -2111,16 +2138,15 @@
      return;

    w = XWINDOW (FRAME_SELECTED_WINDOW (f));
+  if (MINI_WINDOW_P (w))
+    return;
+
    modified_p = (BUF_SAVE_MODIFF (XBUFFER (w->buffer))
  		< BUF_MODIFF (XBUFFER (w->buffer)));
    if (windows_or_buffers_changed
-      /* Minibuffer modification status shown in the close button is
-	 confusing.  */
-      || (!MINI_WINDOW_P (w)
-	  && (modified_p != !NILP (w->last_had_star))))
+      || (modified_p != !NILP (w->last_had_star)))
      {
-      SetWindowModified (FRAME_MAC_WINDOW (f),
-			 !MINI_WINDOW_P (w) && modified_p);
+      SetWindowModified (FRAME_MAC_WINDOW (f), modified_p);
        mac_update_proxy_icon (f);
      }
  #endif

Re: [OS X] Title bar icon

[YAMAMOTO Mitsuharu]

>>>>> On Sun, 26 Aug 2007 11:55:11 -0400, Seiji Zenitani <zenitani@mac.com> said:

> Hi, When visiting a file, the Carbon (OS X) port displays a small
> proxy icon in the window title bar, like other OS X applications.

> However, the proxy icon disappears when the cursor temporary visits
> the mini buffer (i.e. saving the buffer to another file by C-x C-w),
> often enough to attract the user's attention.

Switching to the minibuffer normally causes several visual changes in
the menu bar and the tool bar.  Even the title bar string will change
under multiple frame environments by default.  I don't think the proxy
icon change attracts more user's attention than these changes.

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp

Re: [OS X] Title bar icon

[Seiji Zenitani]

On 2007/08/26, at 20:22, YAMAMOTO Mitsuharu wrote:

>>>>>> On Sun, 26 Aug 2007 11:55:11 -0400, Seiji Zenitani  
>>>>>> <zenitani@mac.com> said:
>
>> Hi, When visiting a file, the Carbon (OS X) port displays a small
>> proxy icon in the window title bar, like other OS X applications.
>
>> However, the proxy icon disappears when the cursor temporary visits
>> the mini buffer (i.e. saving the buffer to another file by C-x C-w),
>> often enough to attract the user's attention.
>
> Switching to the minibuffer normally causes several visual changes in
> the menu bar and the tool bar.  Even the title bar string will change
> under multiple frame environments by default.  I don't think the proxy
> icon change attracts more user's attention than these changes.
>
Thanks for your response.  Both the menu bar change and the tool bar  
change (dimming out) are quite reasonable, while I feel uncomfortable  
with the proxy icon change.

But I agree that the proxy icon should be updated in the mini  
buffer.  As you pointed out, my proposal will introduce inconsistency  
under multiple frame environments -- it is easy to delete the buffer,  
which is related to the proxy icon in other frame.

Seiji Zenitani
zenitani@mac.com

Re: [OS X] Title bar icon

[Richard Stallman]

People, note that we have papers from Seiji Zenitani.

Re: [OS X] Title bar icon

[David Reitter]

[-- Attachment #1.1: Type: text/plain, Size: 815 bytes --]

On 27 Aug 2007, at 01:22, YAMAMOTO Mitsuharu wrote:

>  Switching to the minibuffer normally causes several visual changes in
> the menu bar and the tool bar.  Even the title bar string will change
> under multiple frame environments by default.  I don't think the proxy
> icon change attracts more user's attention than these changes.

Correct. Why not change this behavior completely?
Displaying *Minibuf-1* as title of the frame is confusing, because  
this title is supposed to indicate the "document" shown in the frame,  
which translates to the buffer in the biggest or last activated  
window, but not whether a secondary input field (i.e., minibuffer) is  
selected.

It would be much better if the frame title didn't change at all when  
entering or exiting the minibuffer. This includes the proxy icon.


[-- Attachment #1.2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 2193 bytes --]

[-- Attachment #2: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: [OS X] Title bar icon

[YAMAMOTO Mitsuharu]

>>>>> On Mon, 27 Aug 2007 08:47:34 +0100, David Reitter <david.reitter@gmail.com> said:

>> Switching to the minibuffer normally causes several visual changes
>> in the menu bar and the tool bar.  Even the title bar string will
>> change under multiple frame environments by default.  I don't think
>> the proxy icon change attracts more user's attention than these
>> changes.

> Correct. Why not change this behavior completely?  Displaying
> *Minibuf-1* as title of the frame is confusing, because this title
> is supposed to indicate the "document" shown in the frame, which
> Translates to the buffer in the biggest or last activated window,
> but not whether a secondary input field (i.e., minibuffer) is
> selected.

This argument does not convince me because Emacs is not a so-called
"document-based application" in the sense that a frame is not
dedicated to one editing target.

> It would be much better if the frame title didn't change at all when
> entering or exiting the minibuffer. This includes the proxy icon.

If the frame title behavior is changed as a platform-independent
decision, then the proxy icon behavior should follow that.

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp

Re: [OS X] Title bar icon

[David Reitter]

On 27 Aug 2007, at 09:57, YAMAMOTO Mitsuharu wrote:

>  This argument does not convince me because Emacs is not a so-called
> "document-based application" in the sense that a frame is not
> dedicated to one editing target.

That's actually how I use my Emacs - thanks to `one-buffer-one-frame- 
mode'. So I think this should be configurable.

Perhaps we could add a code to `frame-title-format', which would mean  
the name of the buffer showed in the first window of the frame, and a  
code that would be expanded to the name of the buffer in the selected  
window, but not the minibuffer.

The proxy icon could then be another code in `frame-title-format'.