From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: [patch] automatic multiple grep session Date: Fri, 17 Aug 2007 00:50:09 -0400 Message-ID: References: <20070817.060714.149802751.jet@gyve.org> Reply-To: rms@gnu.org NNTP-Posting-Host: lo.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: sea.gmane.org 1187326041 26257 80.91.229.12 (17 Aug 2007 04:47:21 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 17 Aug 2007 04:47:21 +0000 (UTC) Cc: emacs-devel@gnu.org To: Masatake YAMATO Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 17 06:47:19 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1ILtjy-00009l-Cy for ged-emacs-devel@m.gmane.org; Fri, 17 Aug 2007 06:47:18 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ILtjx-0007d4-QI for ged-emacs-devel@m.gmane.org; Fri, 17 Aug 2007 00:47:17 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ILtjB-0007KP-Lb for emacs-devel@gnu.org; Fri, 17 Aug 2007 00:46:29 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ILtjB-0007K7-5e for emacs-devel@gnu.org; Fri, 17 Aug 2007 00:46:29 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ILtjB-0007K1-1v for emacs-devel@gnu.org; Fri, 17 Aug 2007 00:46:29 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1ILtjA-0007CJ-MX for emacs-devel@gnu.org; Fri, 17 Aug 2007 00:46:28 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.60) (envelope-from ) id 1ILtmj-0002rF-W9; Fri, 17 Aug 2007 00:50:10 -0400 In-reply-to: <20070817.060714.149802751.jet@gyve.org> (message from Masatake YAMATO on Fri, 17 Aug 2007 06:07:14 +0900 (JST)) X-Detected-Kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:76667 Archived-At: +(defcustom grep-use-command-line-as-buffer-name nil + "Use the command line of grep as the name for grep buffer if non-nil. I can't make sense of that sentence, or that variable name. Can you please explain what this feature is intended to do? +(defun grep-make-buffer-name-function (seed-string) + "Make a function that returns a buffer name derived from SEED-STRING. +This is used when `grep-use-command-line-as-buffer-name' is non-nil." + (when grep-use-command-line-as-buffer-name + (eval `(lambda (mode) (format "*%s*" + ,seed-string))))) What's the purpose of calling `eval' here? It is a bad thing to do, when it is not really necessary, and I can't see the purpose of doing so here. Please note that some of the code you changed had its line breaks in the wrong place; I just fixed that.