From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Richard Stallman <rms@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: SVG support(again) ?
Date: Thu, 16 Aug 2007 20:32:00 -0400
Message-ID: <E1ILpku-0002ZE-Vq@fencepost.gnu.org>
References: <m31wedpolf.fsf@kurono.home> <m3odhgo1be.fsf@kurono.home>
	<E1IJjAO-00036h-0I@fencepost.gnu.org> <m3vebijplo.fsf@kurono.home>
	<E1IL5mC-0000ku-UC@fencepost.gnu.org> <m3eji3hmwq.fsf@kurono.home>
Reply-To: rms@gnu.org
NNTP-Posting-Host: lo.gmane.org
Content-Type: text/plain; charset=ISO-8859-15
X-Trace: sea.gmane.org 1187310514 25990 80.91.229.12 (17 Aug 2007 00:28:34 GMT)
X-Complaints-To: usenet@sea.gmane.org
NNTP-Posting-Date: Fri, 17 Aug 2007 00:28:34 +0000 (UTC)
Cc: emacs-devel@gnu.org
To: joakim@verona.se
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 17 02:28:31 2007
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([199.232.76.165])
	by lo.gmane.org with esmtp (Exim 4.50)
	id 1ILphX-0006ai-HD
	for ged-emacs-devel@m.gmane.org; Fri, 17 Aug 2007 02:28:31 +0200
Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43)
	id 1ILphW-0003kK-Vu
	for ged-emacs-devel@m.gmane.org; Thu, 16 Aug 2007 20:28:31 -0400
Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1ILphN-0003f9-3v
	for emacs-devel@gnu.org; Thu, 16 Aug 2007 20:28:21 -0400
Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1ILphL-0003dw-37
	for emacs-devel@gnu.org; Thu, 16 Aug 2007 20:28:20 -0400
Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1ILphK-0003dl-Ts
	for emacs-devel@gnu.org; Thu, 16 Aug 2007 20:28:18 -0400
Original-Received: from fencepost.gnu.org ([140.186.70.10])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <rms@gnu.org>) id 1ILphK-0003Ik-Mk
	for emacs-devel@gnu.org; Thu, 16 Aug 2007 20:28:18 -0400
Original-Received: from rms by fencepost.gnu.org with local (Exim 4.60)
	(envelope-from <rms@gnu.org>)
	id 1ILpku-0002ZE-Vq; Thu, 16 Aug 2007 20:32:01 -0400
In-reply-to: <m3eji3hmwq.fsf@kurono.home> (joakim@verona.se)
X-Detected-Kernel: Linux 2.6, seldom 2.4 (older, 4)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:76653
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/76653>

    /* Structure describing the image type `svg'.  */

    static struct image_type svg_type =
    {
      &Qsvg,
      svg_image_p,
      svg_load,
      x_clear_image,
      NULL
    };

How about adding another comment for each field explaining what
the field means and why this particular value is used.

    /* DEF_IMGLIB_FN() here? */

I don't understand that comment -- if you do, could you make
it less terse, and clear?

    /* helper function for svg_load, does the actual loading
     given contents and size, apart from frame and image structures, passed from svg_load

     Uses librsvg to do most of the image processing.

     Returns non-zero when sucessful
    */

That is terse and cryptic.  Could you rewrite it to be clear
and format it the way we like to do?

The code of svg_load_image needs more comments explaining what the
parts of the code do.