From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: Re: completion.el -- should use buffer-substring-no-properties instead of buffer-string Date: Wed, 15 Aug 2007 21:08:19 -0400 Message-ID: References: <20070815073505.95E1F12A4071@localhost> Reply-To: rms@gnu.org NNTP-Posting-Host: lo.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: sea.gmane.org 1187226353 1688 80.91.229.12 (16 Aug 2007 01:05:53 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 16 Aug 2007 01:05:53 +0000 (UTC) To: emacs-pretest-bug@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Aug 16 03:05:49 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1ILTna-0000Oc-PW for ged-emacs-devel@m.gmane.org; Thu, 16 Aug 2007 03:05:42 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ILTnY-00021B-UD for ged-emacs-devel@m.gmane.org; Wed, 15 Aug 2007 21:05:16 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ILTn1-0001ea-Lw for emacs-devel@gnu.org; Wed, 15 Aug 2007 21:04:43 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ILTn0-0001dz-Jf for emacs-devel@gnu.org; Wed, 15 Aug 2007 21:04:42 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ILTn0-0001dt-Bk for emacs-devel@gnu.org; Wed, 15 Aug 2007 21:04:42 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1ILTmz-0003IN-Pt for emacs-devel@gnu.org; Wed, 15 Aug 2007 21:04:41 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.60) (envelope-from ) id 1ILTqV-0002Vx-C4; Wed, 15 Aug 2007 21:08:19 -0400 In-reply-to: <20070815073505.95E1F12A4071@localhost> (message from raman on Wed, 15 Aug 2007 00:35:05 -0700 (PDT)) X-Detected-Kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:76604 gmane.emacs.pretest.bugs:19548 Archived-At: Does anyone see a problem with this change? From: raman To: emacs-pretest-bug@gnu.org From: "T. V. Raman" Date: Wed, 15 Aug 2007 00:35:05 -0700 (PDT) Cc: Subject: completion.el -- should use buffer-substring-no-properties instead of buffer-string I fixed this a while ago in my local copy of Emacs and have been using it without any unforeseen consequences for a while, so I thought it was time to submit this as a patch: In completion.el, completions are stored to the completions file along with text properties --- the text properties dont achieve anything in this case. There are a total of four instances of calls to buffer-substring in completion.el -- I did a global replace to use buffer-substring-no-properties In GNU Emacs 22.1.50.19 (i686-pc-linux-gnu, GTK+ Version 2.8.20) of 2007-08-14 on labrador configured using `configure '--prefix=/usr/local' '--with-toolkit=gtk'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: en_US.UTF-8 locale-coding-system: utf-8 default-enable-multibyte-characters: nil Major mode: Shell Minor modes in effect: jabber-activity-mode: t dired-omit-mode: t dynamic-completion-mode: t shell-dirtrack-mode: t savehist-mode: t display-time-mode: t desktop-save-mode: t auto-insert-mode: t encoded-kbd-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t unify-8859-on-encoding-mode: t utf-translate-cjk-mode: t auto-compression-mode: t Recent input: s e SPC d e f a u l t SPC h e a d e r SPC l i n e SPC i f SPC n o n e SPC s e t SPC t o SPC s p e a k SPC b u f f e r ESC DEL ESC DEL s h o w SPC b u f f e r SPC n a m e . " ; SPC m a k e RET C-e m C-e x v 1 RET ESC < C-n C-n C-n C-n C-n ESC > C-p C-p C-p C-p C-p C-p C-p C-p C-p C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-e m C-e ESC t C-e C-w C-x 1 ESC < C-e C-w C-n ESC > C-p C-p C-x 4 b c a l RET C-e ESC t C-x o ESC [ [ C ESC [ [ C ESC [ 2 3 ~ C-x o C-e x v 1 RET C-x 1 ESC < C-n C-n ESC > C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p ESC < C-e m C-e SPC ESC [ 2 3 ~ ESC [ K ESC [ 2 3 ~ c d RET c d SPC e m TAB l i TAB e m TAB RET ESC x l o a d SPC l i RET e m a c s p e a k - a d v TAB RET C-e a ESC [ K ESC [ L ESC [ L ESC [ L ESC [ L C-e x DEL ESC [ 2 3 ~ C-e m c d RET C-e m C-e m C-e m ESC x r e p o r t SPC e m TAB b TAB RET Recent messages: ~ Loading emacsbug...done Thanks, --Raman -- Best Regards, --raman Email: raman@users.sf.net WWW: http://emacspeak.sf.net/raman/ AIM: emacspeak GTalk: tv.raman.tv@gmail.com PGP: http://emacspeak.sf.net/raman/raman-almaden.asc Google: tv+raman IRC: irc://irc.freenode.net/#emacs _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-devel