From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: C-x v l does not move to current log entry Date: Sun, 12 Aug 2007 00:15:07 -0400 Message-ID: References: <46B03B75.4000008@swipnet.se> <18099.60849.120058.919034@rgrjr.dyndns.org> Reply-To: rms@gnu.org NNTP-Posting-Host: lo.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: sea.gmane.org 1186891932 17504 80.91.229.12 (12 Aug 2007 04:12:12 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 12 Aug 2007 04:12:12 +0000 (UTC) Cc: Bob Rogers To: emacs-devel@gnu.org, esr@snark.thyrsus.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Aug 12 06:12:10 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IK4oE-0008AJ-2m for ged-emacs-devel@m.gmane.org; Sun, 12 Aug 2007 06:12:10 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IK4oD-0007TV-GE for ged-emacs-devel@m.gmane.org; Sun, 12 Aug 2007 00:12:09 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IK4nw-0007K2-6e for emacs-devel@gnu.org; Sun, 12 Aug 2007 00:11:52 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IK4nv-0007Iu-8I for emacs-devel@gnu.org; Sun, 12 Aug 2007 00:11:51 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IK4nu-0007If-Sr for emacs-devel@gnu.org; Sun, 12 Aug 2007 00:11:51 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IK4nu-0003FX-Hw for emacs-devel@gnu.org; Sun, 12 Aug 2007 00:11:50 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.60) (envelope-from ) id 1IK4r5-0006VJ-0a; Sun, 12 Aug 2007 00:15:07 -0400 In-Reply-To: <18099.60849.120058.919034@rgrjr.dyndns.org> (message from Bob Rogers on Fri, 3 Aug 2007 23:08:33 -0400) X-Detected-Kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:76369 Archived-At: [I sent this message a week ago but did not get a response. Could we get the discussion moving again?] Bob, thanks for making some progress. Would someone else please take this the rest of the way, DTRT, and ack? MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="aPqeXV8Jxn" Date: Fri, 3 Aug 2007 23:08:33 -0400 From: Bob Rogers To: rms@gnu.org CC: emacs-devel@gnu.org, esr@snark.thyrsus.com Subject: Re: C-x v l does not move to current log entry In-Reply-To: --aPqeXV8Jxn Content-Type: text/plain; charset=iso-8859-1 Content-Description: message body text Content-Transfer-Encoding: 8bit From: Richard Stallman Date: Thu, 02 Aug 2007 11:45:17 -0400 Would someone please DTRT and ack? Date: Wed, 01 Aug 2007 09:51:17 +0200 From: Jan Djärv % emacs -Q src/gmalloc.c C-x v l The cursor stays at the top of the log view buffer. Contrast this to emacs 22.1 where the cursor is positioned to the current log entry for the revision of src/gmalloc.c that you are editing. Hmm. vc-default-show-log-entry does appear to be going to the right place, but something is messing it up afterwards. I think I'll go to bed now and let somebody who knows what they're doing have a crack at it. ;-} This from *Messages* may be relevant: Running cvs log gmalloc.c in the background... done Loading log-view... Loading easy-mmode...done Loading log-view...done Error during redisplay: (void-function ,log-view-file-re) [2 times] This turns out to be coming from log-view-font-lock-keywords, which has a value that looks something like this: ((eval \` (\,log-view-file-re (1 ...) (0 log-view-file-face append))) (eval \` (\,log-view-message-re . log-view-message-face))) The source (log-view.el:170) specifies backquoted forms inside a quoted form; it appears that the reader is not handling this correctly. The attached patch replaces the backquotes with explicit "cons" calls; this is not a real fix, and I include it only to show that it does make the error messages go away. Fixing the reader is undoubtedly hairier. However, fixing the "Error during redisplay" problem does not affect the original symptom. Hope this is of some use, -- Bob Rogers http://rgrjr.dyndns.org/ --aPqeXV8Jxn Content-Type: text/plain Content-Description: Content-Disposition: inline; filename="no-bq-in-log-view-flk-1.patch" Content-Transfer-Encoding: 7bit Index: lisp/log-view.el =================================================================== RCS file: /sources/emacs/emacs/lisp/log-view.el,v retrieving revision 1.37 diff -c -r1.37 log-view.el *** lisp/log-view.el 23 Jun 2007 03:06:21 -0000 1.37 --- lisp/log-view.el 4 Aug 2007 02:41:52 -0000 *************** *** 170,179 **** (defvar log-view-font-lock-keywords ;; We use `eval' so as to use the buffer-local value of log-view-file-re ;; and log-view-message-re, if applicable. ! '((eval . `(,log-view-file-re ! (1 (if (boundp 'cvs-filename-face) cvs-filename-face)) ! (0 log-view-file-face append))) ! (eval . `(,log-view-message-re . log-view-message-face)))) (defconst log-view-font-lock-defaults '(log-view-font-lock-keywords t nil nil nil)) --- 170,180 ---- (defvar log-view-font-lock-keywords ;; We use `eval' so as to use the buffer-local value of log-view-file-re ;; and log-view-message-re, if applicable. ! '((eval . (cons log-view-file-re ! '((1 (if (boundp 'cvs-filename-face) cvs-filename-face)) ! (0 log-view-file-face append)))) ! (eval . (cons log-view-message-re ! 'log-view-message-face)))) (defconst log-view-font-lock-defaults '(log-view-font-lock-keywords t nil nil nil)) --aPqeXV8Jxn--