unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Richard Stallman <rms@gnu.org>
To: "Stephen J. Turnbull" <stephen@xemacs.org>
Cc: dann@ics.uci.edu, mwolson@gnu.org, emacs-devel@gnu.org
Subject: Re: [PATCH] Disable VC when Emacs is noninteractive -batch
Date: Mon, 06 Aug 2007 12:33:52 -0400	[thread overview]
Message-ID: <E1II5Wi-0006MD-2Z@fencepost.gnu.org> (raw)
In-Reply-To: <877io99yoh.fsf@uwakimon.sk.tsukuba.ac.jp> (stephen@xemacs.org)

    IMO, if VC's hooks are active in batch mode, that's a bug.

I don't see why.

      You don't
    want programs that are *implicitly* sensitive to environment state
    active in batch mode.

I don't follow at all.  If "environment state" means the file system,
we certainly don't expect commands that operate on files to be
insensitive to that.

      (I'm sure there are good reasons for using VC
    noninteractively, although I personally don't use it in batch mode.
    But such programs should call VC functions explicitly.)

VC only does anything when you call VC functions explicitly.
Unless it has a bug.

    > That is not the only reason.  I want vc disabled when in -batch mode
    > because it is (1) useless there, (2) delays compilation, and (3)
    > displays many "loading vc-<system>..." messages that clutter the
    > compilation output.

It would be harmless and easy to turn off VC for batch mode
compilation.  We just have to change the commands that do this
compilation:

*** bytecomp.el	26 Jul 2007 12:57:26 -0400	2.204
--- bytecomp.el	06 Aug 2007 11:47:18 -0400	
***************
*** 4124,4130 ****
    (defvar command-line-args-left)	;Avoid 'free variable' warning
    (if (not noninteractive)
        (error "`batch-byte-compile' is to be used only with -batch"))
!   (let ((error nil))
      (while command-line-args-left
        (if (file-directory-p (expand-file-name (car command-line-args-left)))
  	  ;; Directory as argument.
--- 4124,4131 ----
    (defvar command-line-args-left)	;Avoid 'free variable' warning
    (if (not noninteractive)
        (error "`batch-byte-compile' is to be used only with -batch"))
!   (let ((error nil)
! 	(vc-handled-backends nil))
      (while command-line-args-left
        (if (file-directory-p (expand-file-name (car command-line-args-left)))
  	  ;; Directory as argument.
***************
*** 4192,4198 ****
    (or command-line-args-left
        (setq command-line-args-left '(".")))
    (while command-line-args-left
!     (byte-recompile-directory (car command-line-args-left) arg)
      (setq command-line-args-left (cdr command-line-args-left)))
    (kill-emacs 0))
  
--- 4193,4200 ----
    (or command-line-args-left
        (setq command-line-args-left '(".")))
    (while command-line-args-left
!     (let ((vc-handled-backends nil))
!       (byte-recompile-directory (car command-line-args-left) arg))
      (setq command-line-args-left (cdr command-line-args-left)))
    (kill-emacs 0))

  reply	other threads:[~2007-08-06 16:33 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-05 19:39 [PATCH] Disable VC when Emacs is noninteractive -batch Michael Olson
2007-08-05 22:06 ` Dan Nicolaescu
2007-08-06  1:32   ` Michael Olson
2007-08-06  5:20     ` Miles Bader
2007-08-06  2:36   ` Stephen J. Turnbull
2007-08-06 16:33     ` Richard Stallman [this message]
2007-08-06 18:07       ` Stephen J. Turnbull
2007-08-07  7:29         ` Richard Stallman
2007-08-07  8:59           ` Stephen J. Turnbull
2007-08-07 20:12             ` Richard Stallman
2007-08-06 20:46       ` Michael Olson
2007-08-06 21:22         ` Jason Rumney
2007-08-07  7:29         ` Richard Stallman
2007-08-07 10:18           ` David Kastrup
2007-08-07 20:12             ` Richard Stallman
2007-08-07 20:46               ` David Kastrup
2007-08-07 11:40           ` Michael Olson
2007-08-08  4:54             ` Richard Stallman
2007-08-08 13:07               ` Stefan Monnier
2007-08-08 13:29               ` Michael Olson
2007-08-09  5:23                 ` Richard Stallman
2007-08-07 15:53         ` Edward O'Connor
2007-08-06 14:19 ` Richard Stallman
2007-08-06 18:38 ` Stefan Monnier
2007-08-06 19:16   ` David Kastrup
2007-08-07  0:44     ` Miles Bader
2007-08-07  3:08     ` Eli Zaretskii
2007-08-07  6:07       ` David Kastrup
2007-08-07  6:51         ` Michael Olson
2007-08-07 20:11         ` Richard Stallman
2007-08-07 20:42           ` David Kastrup
2007-08-09  0:06             ` Richard Stallman
2007-08-09  0:17               ` David Kastrup
2007-08-11 16:38                 ` chad brown
2007-08-12 17:56                   ` Richard Stallman
2007-08-15  4:14                     ` chad brown
2007-08-16  1:08                       ` Richard Stallman
2007-08-14 15:46                   ` Davis Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1II5Wi-0006MD-2Z@fencepost.gnu.org \
    --to=rms@gnu.org \
    --cc=dann@ics.uci.edu \
    --cc=emacs-devel@gnu.org \
    --cc=mwolson@gnu.org \
    --cc=stephen@xemacs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).