* typo? in tty_supports_face_attributes_p
@ 2007-08-05 19:28 Masatake YAMATO
2007-08-06 14:19 ` Richard Stallman
0 siblings, 1 reply; 2+ messages in thread
From: Masatake YAMATO @ 2007-08-05 19:28 UTC (permalink / raw)
To: emacs-devel
Can I ask you to review following patch?
While reading xfaces.c, I found unsymmetrical code.
I guess these are typos. However I could not find the way
to reproduce a bug which these typos cause quickly.
If you know well about these area, could you take your
time to review this patch? Forgive me my lazyness.
Thanks in advance.
Masatake
--- xfaces.c 26 7月 2007 14:28:01 +0900 1.362
+++ xfaces.c 06 8月 2007 04:19:02 +0900
@@ -6066,7 +6066,7 @@
val = attrs[LFACE_INVERSE_INDEX];
if (!UNSPECIFIEDP (val))
{
- if (face_attr_equal_p (val, def_attrs[LFACE_UNDERLINE_INDEX]))
+ if (face_attr_equal_p (val, def_attrs[LFACE_INVERSE_INDEX]))
return 0; /* same as default */
else
test_caps |= TTY_CAP_INVERSE;
@@ -6109,7 +6109,7 @@
bg = attrs[LFACE_BACKGROUND_INDEX];
if (STRINGP (bg))
{
- Lisp_Object def_bg = def_attrs[LFACE_FOREGROUND_INDEX];
+ Lisp_Object def_bg = def_attrs[LFACE_BACKGROUND_INDEX];
if (face_attr_equal_p (bg, def_bg))
return 0; /* same as default */
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: typo? in tty_supports_face_attributes_p
2007-08-05 19:28 typo? in tty_supports_face_attributes_p Masatake YAMATO
@ 2007-08-06 14:19 ` Richard Stallman
0 siblings, 0 replies; 2+ messages in thread
From: Richard Stallman @ 2007-08-06 14:19 UTC (permalink / raw)
To: Masatake YAMATO; +Cc: emacs-devel
Your patch looks correct, so I will install it. Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-08-06 14:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-05 19:28 typo? in tty_supports_face_attributes_p Masatake YAMATO
2007-08-06 14:19 ` Richard Stallman
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).