unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Richard Stallman <rms@gnu.org>
To: tromey@redhat.com
Cc: joakim@verona.se, emacs-devel@gnu.org
Subject: Re: status of dir-vars or dir-locals inclusion in emacs?
Date: Tue, 31 Jul 2007 13:05:46 -0400	[thread overview]
Message-ID: <E1IFvAI-0003B2-OX@fencepost.gnu.org> (raw)
In-Reply-To: <m36442olyh.fsf@fleche.redhat.com> (message from Tom Tromey on Sun, 29 Jul 2007 16:59:34 -0600)

    I did want to ask whether this is something that should be enabled by
    default.

Definitely.

It looks ready to install, as far as I can see, aside from some
minor points.  Do you disagree?


    (defun project-install-bindings-from-alist (mode-alist)
      "Apply local variable settings from MODE-ALIST."
      (mapc (lambda (pair)
	      (let ((variable (car pair))

Using dolist would be clearer (and more efficient).

    ;; - need a way to add to auto-mode-alist per-project
    ;;   e.g., semantic wants GCC's .def files to be c-mode
    ;;   (RMS points out that this is also easily done by adding comments
    ;;   to the particular files.)

The point is, we don't need another way to do it,
so that item should be deleted.

    ;; - maybe an easy way to integrate with customize?

That would be a very good feature to add.

    ;; - per-project and per-mode new file skeletons

I don't think that is very important.

Some doc comments:

The comments at the start of the file tend to use passive voice:

      Settings can be
    ;; checked in to the project's version control and they will
    ;; automatically be found and used by Emacs.

    ;; A project class can be defined manually using
    ;; `define-project-bindings'.  Then a directory can be associated with a
    ;; given class using `set-directory-project'.

The active voice is easier to read, and clearer, because it states the
subject.  Can you please rewrite all the passive voice sentences to active,
except when there is some very strong specific reason to use passive voice?

    ;; When a file is loaded, project.el will search up the directory
    ;; hierarchy.

Please stick to present tense except when that won't work.

;; (define-project-bindings 'gcc
;;   '((nil . ((indent-tabs-mode . t)
;; 	    (tab-width . 8)
;; 	    (fill-column . 80)))

That's not indented right.

  parent reply	other threads:[~2007-07-31 17:05 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-03 13:48 status of dir-vars or dir-locals inclusion in emacs? joakim
2007-07-04  0:25 ` Tom Tromey
2007-07-10 22:01   ` Richard Stallman
2007-07-29 22:59     ` Tom Tromey
2007-07-30 14:45       ` Stefan Monnier
2007-07-30 15:08         ` Tom Tromey
2007-08-03 17:29           ` Vagn Johansen
2007-08-03 22:02             ` Richard Stallman
2007-08-04  7:02               ` David Kastrup
2007-08-05  3:05                 ` Richard Stallman
2007-07-31 17:05       ` Richard Stallman [this message]
2007-07-31 18:45         ` Stefan Monnier
2007-09-01 22:40         ` Tom Tromey
2007-09-02 11:56           ` Vagn Johansen
2007-09-03  3:04             ` Richard Stallman
2007-09-03 18:25           ` Richard Stallman
2007-09-04 21:53             ` Dan Nicolaescu
2007-09-05  3:16               ` Stefan Monnier
2007-09-05 17:32                 ` Dan Nicolaescu
2007-09-05 18:18                   ` Stefan Monnier
2007-09-05 18:04                     ` Tom Tromey
2007-09-05 18:28                   ` David Kastrup
2007-09-05  6:16               ` Richard Stallman
2007-09-05 14:06                 ` Stefan Monnier
2007-09-05 14:36                   ` Davis Herring
2007-09-03 18:26           ` Richard Stallman
2007-07-04 17:04 ` Vagn Johansen
2007-07-05  1:29 ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1IFvAI-0003B2-OX@fencepost.gnu.org \
    --to=rms@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=joakim@verona.se \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).