From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: highlight failed part of isearch input Date: Tue, 24 Jul 2007 12:45:55 -0400 Message-ID: References: <87k5sqerle.fsf@jurta.org> Reply-To: rms@gnu.org NNTP-Posting-Host: lo.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: sea.gmane.org 1185295611 11780 80.91.229.12 (24 Jul 2007 16:46:51 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 24 Jul 2007 16:46:51 +0000 (UTC) Cc: drew.adams@oracle.com, emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 24 18:46:50 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IDNX7-0005rf-2P for ged-emacs-devel@m.gmane.org; Tue, 24 Jul 2007 18:46:49 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IDNX6-0007Bo-Mm for ged-emacs-devel@m.gmane.org; Tue, 24 Jul 2007 12:46:48 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IDNUi-0004D6-GB for emacs-devel@gnu.org; Tue, 24 Jul 2007 12:44:20 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IDNUg-00048g-HV for emacs-devel@gnu.org; Tue, 24 Jul 2007 12:44:19 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IDNUg-000487-9P for emacs-devel@gnu.org; Tue, 24 Jul 2007 12:44:18 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IDNUg-0000UA-0m for emacs-devel@gnu.org; Tue, 24 Jul 2007 12:44:18 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.60) (envelope-from ) id 1IDNWF-0002qo-E7; Tue, 24 Jul 2007 12:45:55 -0400 In-reply-to: <87k5sqerle.fsf@jurta.org> (message from Juri Linkov on Tue, 24 Jul 2007 00:29:49 +0300) X-detected-kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:75462 Archived-At: I like this proposal but there is a problem in the patch: (when (string-match " +$" m) (propertize (substring m (match-beginning 0)) 'face 'trailing-whitespace)) This is a no-op. Yes, if it is used for effect. But maybe it is good to remove this code because the failed trailing whitespace is highlighted in the new face isearch-failed. I don't entirely understand. What change are you proposing?