[ojacobson@riptown.com: Usernames with @ signs break "file being modified by another user" lock symlinks]

[ojacobson@riptown.com: Usernames with @ signs break "file being modified by another user" lock symlinks]

[Richard Stallman]

Does this problem still happen in Emacs 22?  If so,
we should try to fix it.  Perhaps the solution is to make filelock.c
replace @ with some other, harmless character.

Would someone please DTRT and ack?

------- Start of forwarded message -------
X-Spam-Status: No, score=0.0 required=5.0 tests=UNPARSEABLE_RELAY 
	autolearn=failed version=3.1.0
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-class: urn:content-classes:message
Date: Wed, 4 Jul 2007 11:56:01 -0700
Thread-Topic: Usernames with @ signs break "file being modified by another
	user" lock symlinks
Thread-Index: Ace+bPbRNXE5CCpgEdy/dwAX8giFnA==
From: "Owen Jacobson" <ojacobson@riptown.com>
To: <bug-gnu-emacs@gnu.org>
Subject: Usernames with @ signs break "file being modified by another user"
	lock symlinks

This bug report will be sent to the Free Software Foundation,
not to your local site managers!
Please write in English, because the Emacs maintainers do not have
translators to read other languages for them.

Your bug report will be posted to the bug-gnu-emacs@gnu.org mailing list,
and to the gnu.emacs.bug news group.

In GNU Emacs 21.2.1 (powerpc-apple-darwin8.0)
 of 2007-05-08 on s11-cp04-07.corp.kazootek.com
configured using `configure  --prefix=/usr --mandir=/usr/share/man
- --infodir=/usr/share/info --disable-dependency-tracking --without-x'
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: nil
  locale-coding-system: nil
  default-enable-multibyte-characters: t

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

1.  Create a username* with an @ symbol in it (eg "test@localhost") and su
to it.
2.  emacs test.txt
3.  Enter some text and attempt to save it.

Emacs will warn that the file is in use by another process and report
its own PID, despite being the only editor accessing the file.  Examining
the output of ls -l while this prompt is displayed shows a symlink named
.#filename, linked to test@localhost@MACHINENAME.PID

I've verified this on a linux system with a normal local user named
"test@localhost" as well; this is not dependant on directory-based
usernames.

* This came up because the machine I normally use, a Mac, has been
  bound into an OpenDirectory domain and my username (as seen in $USER
  and friends) is ojacobson@DOMAIN.COM.



_______________________________________________
bug-gnu-emacs mailing list
bug-gnu-emacs@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-gnu-emacs
------- End of forwarded message -------

[ojacobson@riptown.com: Usernames with @ signs break "file being modified by another user" lock symlinks]

[Richard Stallman]

[I sent this message a few weeks ago but did not get a response.
Could we get the discussion moving again?]

I think this problem still happens in Emacs 22.
I think the fix is to establish a quoting convention
for strange characters in the user name.  Perhaps quoted printable
encoding.

Would someone please DTRT and ack?

------- Start of forwarded message -------
X-Spam-Status: No, score=0.0 required=5.0 tests=UNPARSEABLE_RELAY 
	autolearn=failed version=3.1.0
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-class: urn:content-classes:message
Date: Wed, 4 Jul 2007 11:56:01 -0700
Thread-Topic: Usernames with @ signs break "file being modified by another
	user" lock symlinks
Thread-Index: Ace+bPbRNXE5CCpgEdy/dwAX8giFnA==
From: "Owen Jacobson" <ojacobson@riptown.com>
To: <bug-gnu-emacs@gnu.org>
Subject: Usernames with @ signs break "file being modified by another user"
	lock symlinks

This bug report will be sent to the Free Software Foundation,
not to your local site managers!
Please write in English, because the Emacs maintainers do not have
translators to read other languages for them.

Your bug report will be posted to the bug-gnu-emacs@gnu.org mailing list,
and to the gnu.emacs.bug news group.

In GNU Emacs 21.2.1 (powerpc-apple-darwin8.0)
 of 2007-05-08 on s11-cp04-07.corp.kazootek.com
configured using `configure  --prefix=/usr --mandir=/usr/share/man
- --infodir=/usr/share/info --disable-dependency-tracking --without-x'
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: nil
  locale-coding-system: nil
  default-enable-multibyte-characters: t

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

1.  Create a username* with an @ symbol in it (eg "test@localhost") and su
to it.
2.  emacs test.txt
3.  Enter some text and attempt to save it.

Emacs will warn that the file is in use by another process and report
its own PID, despite being the only editor accessing the file.  Examining
the output of ls -l while this prompt is displayed shows a symlink named
.#filename, linked to test@localhost@MACHINENAME.PID

I've verified this on a linux system with a normal local user named
"test@localhost" as well; this is not dependant on directory-based
usernames.

* This came up because the machine I normally use, a Mac, has been
  bound into an OpenDirectory domain and my username (as seen in $USER
  and friends) is ojacobson@DOMAIN.COM.



_______________________________________________
bug-gnu-emacs mailing list
bug-gnu-emacs@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-gnu-emacs
------- End of forwarded message -------

[ojacobson@riptown.com: Usernames with @ signs break "file being modified by another user" lock symlinks]

[Richard Stallman]

[I sent this message twice but did not get a response.
Could we get the discussion moving again?]

I think this problem still happens in Emacs 22.
I think the fix is to establish a quoting convention
for strange characters in the user name.  Perhaps quoted printable
encoding.

Would someone please DTRT and ack?

------- Start of forwarded message -------
X-Spam-Status: No, score=0.0 required=5.0 tests=UNPARSEABLE_RELAY 
	autolearn=failed version=3.1.0
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-class: urn:content-classes:message
Date: Wed, 4 Jul 2007 11:56:01 -0700
Thread-Topic: Usernames with @ signs break "file being modified by another
	user" lock symlinks
Thread-Index: Ace+bPbRNXE5CCpgEdy/dwAX8giFnA==
From: "Owen Jacobson" <ojacobson@riptown.com>
To: <bug-gnu-emacs@gnu.org>
Subject: Usernames with @ signs break "file being modified by another user"
	lock symlinks

This bug report will be sent to the Free Software Foundation,
not to your local site managers!
Please write in English, because the Emacs maintainers do not have
translators to read other languages for them.

Your bug report will be posted to the bug-gnu-emacs@gnu.org mailing list,
and to the gnu.emacs.bug news group.

In GNU Emacs 21.2.1 (powerpc-apple-darwin8.0)
 of 2007-05-08 on s11-cp04-07.corp.kazootek.com
configured using `configure  --prefix=/usr --mandir=/usr/share/man
- --infodir=/usr/share/info --disable-dependency-tracking --without-x'
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: nil
  locale-coding-system: nil
  default-enable-multibyte-characters: t

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

1.  Create a username* with an @ symbol in it (eg "test@localhost") and su
to it.
2.  emacs test.txt
3.  Enter some text and attempt to save it.

Emacs will warn that the file is in use by another process and report
its own PID, despite being the only editor accessing the file.  Examining
the output of ls -l while this prompt is displayed shows a symlink named
.#filename, linked to test@localhost@MACHINENAME.PID

I've verified this on a linux system with a normal local user named
"test@localhost" as well; this is not dependant on directory-based
usernames.

* This came up because the machine I normally use, a Mac, has been
  bound into an OpenDirectory domain and my username (as seen in $USER
  and friends) is ojacobson@DOMAIN.COM.



_______________________________________________
bug-gnu-emacs mailing list
bug-gnu-emacs@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-gnu-emacs
------- End of forwarded message -------

Re: [ojacobson@riptown.com: Usernames with @ signs break "file being modified by another user" lock symlinks]

[Jason Rumney]

Richard Stallman wrote:
> [I sent this message twice but did not get a response.
> Could we get the discussion moving again?]
>
> I think this problem still happens in Emacs 22.
> I think the fix is to establish a quoting convention
> for strange characters in the user name.  Perhaps quoted printable
> encoding.
>   

The problem seems to come not from the fact that @ is a special
character, but from the following code, which assumes that @ does not
appear in the username. Since @ cannot appear in hostnames, nor in
timestamps or pids AFAIK, we can probably fix this by changing index to
rindex in the third line below. I don't think any system allows
characters in the username that are not valid in the filename, so this
should be sufficient.

  /* Parse USER@HOST.PID:BOOT_TIME.  If can't parse, return -1.  */
  /* The USER is everything before the first @.  */
  at = index (lfinfo, '@');
  dot = rindex (lfinfo, '.');

Re: [ojacobson@riptown.com: Usernames with @ signs break "file being modified by another user" lock symlinks]

[Richard Stallman]

Would you please implement that approach, then ack?

Re: [ojacobson@riptown.com: Usernames with @ signs break "file being modified by another user" lock symlinks]

[Jason Rumney]

Richard Stallman wrote:
> Would you please implement that approach, then ack?
>   

Checked into the Emacs 22 branch.