unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Francesco Potorti` <pot@gnu.org>
To: rms@gnu.org
Cc: emacs-devel@gnu.org
Subject: Re: etags.el tags-search use global syntax table
Date: Sat, 21 Jul 2007 18:58:00 +0200	[thread overview]
Message-ID: <E1ICIHI-0005AL-Cp@tucano.isti.cnr.it> (raw)
In-Reply-To: <E1IBskb-0004hx-GI@fencepost.gnu.org>

>    +The optional argument KEEP-IF-CLASS is a list of symbols. If the
>    +major mode has any of these symbols in its mode-class property, or if
>    +one the symbols in the list is t, we do not set the major mode."
>
>I am not sure what that means.  Does it mean that if I pass (t foo)
>for KEEP-IF-CLASS, then set-auto-mode will certainly not set the major
>mode?

Yes.

>That is what the words seem to say -- but it doesn't seem useful.
>What's the point of calling set-auto-mode and never setting the major mode?

Those three lines were meant to present the gist of the change, that is,
an abstract of the following patch.  But I made another change, that is,
the patched set-auto-mode returns the chosen mode.  I think this may be
useful for programs that want to know which mode a buffer should be in,
but do not want to set it.

>Also, if you want a way to do that, why make the signal be a list
>containing t?  Why not just pass t as the argument?  Why make it a
>list if the rest of the list is irrelevant?

Yes, passing just t would certainly be clearer.  I thought that having
always a list would be simpler to use and possibly more flexible, but I
would certainly make that change if you think it is best.

>One other question.  Since set-auto-mode doesn't look at mode: local
>bindings, is it sufficient?

Well, no, it is not.  I had overlooked that problem, thanks.

>Aside from that, it looks good.  Next question is how fast it runs.

When I manage to find some more time, I'll look into the mode: local
bindings and do some speed tests.  

  reply	other threads:[~2007-07-21 16:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1IAlXn-000690-C1@tucano.isti.cnr.it>
     [not found] ` <E1IB1MF-0008Id-Cg@fencepost.gnu.org>
2007-07-18 12:54   ` etags.el tags-search use global syntax table Francesco Potorti`
2007-07-18 13:38     ` Andreas Schwab
2007-07-18 14:21       ` Francesco Potorti`
2007-07-19  4:25     ` Richard Stallman
2007-07-19 16:49       ` Francesco Potorti`
2007-07-20 13:42         ` Richard Stallman
2007-07-21 16:58           ` Francesco Potorti` [this message]
2007-07-22 10:05             ` Richard Stallman
2007-07-17 11:49 Francesco Potorti`

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1ICIHI-0005AL-Cp@tucano.isti.cnr.it \
    --to=pot@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).