From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: find-file-noselect needs save-match-data Date: Mon, 25 Jun 2007 09:19:36 -0400 Message-ID: References: <87zm3515r4.fsf@jurta.org> <85k5u8x2gm.fsf@lola.goethe.zz> <87r6og6czf.fsf@catnip.gol.com> <85bqfkx0i5.fsf@lola.goethe.zz> <87odjjzaoz.fsf@catnip.gol.com> <85ps3xoui7.fsf@lola.goethe.zz> <857iq3n2b3.fsf@lola.goethe.zz> <85myyxkfl4.fsf@lola.goethe.zz> <85zm2xhrd7.fsf@lola.goethe.zz> <85wsxzh8gt.fsf@lola.goethe.zz> Reply-To: rms@gnu.org NNTP-Posting-Host: lo.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: sea.gmane.org 1182777710 15052 80.91.229.12 (25 Jun 2007 13:21:50 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 25 Jun 2007 13:21:50 +0000 (UTC) Cc: miles.bader@necel.com, schwab@suse.de, emacs-devel@gnu.org, juri@jurta.org, monnier@iro.umontreal.ca, miles@gnu.org To: David Kastrup Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 25 15:21:48 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1I2oVl-0000sM-4d for ged-emacs-devel@m.gmane.org; Mon, 25 Jun 2007 15:21:45 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1I2oVk-0000SM-HX for ged-emacs-devel@m.gmane.org; Mon, 25 Jun 2007 09:21:44 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1I2oTj-0007yC-CO for emacs-devel@gnu.org; Mon, 25 Jun 2007 09:19:39 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1I2oTi-0007x3-Qz for emacs-devel@gnu.org; Mon, 25 Jun 2007 09:19:38 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1I2oTi-0007wk-CO for emacs-devel@gnu.org; Mon, 25 Jun 2007 09:19:38 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1I2oTi-00012H-43 for emacs-devel@gnu.org; Mon, 25 Jun 2007 09:19:38 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.60) (envelope-from ) id 1I2oTg-0004Xr-VS; Mon, 25 Jun 2007 09:19:36 -0400 In-reply-to: <85wsxzh8gt.fsf@lola.goethe.zz> (message from David Kastrup on Wed, 20 Jun 2007 00:42:42 +0200) X-detected-kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:73813 Archived-At: > Using markers helps avoid strange results when the code inside the > construct edits the buffer. I think that is a good reason for this > feature. It is neither documented in the Elisp manual nor in the DOC string That is true. Details like this don't always have to be documented, but maybe this one should be. and is not the functionality the function is intended to provide. Isn't it? It is also inconsistent with save_search_regs in search.c which means that the documentation in You are right. save_search_regs was written in a way that was inconsistent with the already-existing save-match-data. Is this a real problem? Do we need to change save_search_regs? I hope not, because it would cause a slowdown. But no so much of one, since it only does anything if there is a real search inside the sentinel or filter. One annoying thing is that the use of save-match-data by the sentinel or filter won't prevent save_search_regs from also doing its thing. If save-match-data were implemented in C, it could do so.