From: Kenichi Handa <handa@m17n.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: rudalics@gmx.at, herberteuler@hotmail.com, emacs-devel@gnu.org,
rms@gnu.org, acm@muc.de
Subject: Re: C++ mode and c-beginning-of-current-token
Date: Mon, 21 May 2007 22:01:55 +0900 [thread overview]
Message-ID: <E1Hq7WN-00014F-1A@etlken.m17n.org> (raw)
In-Reply-To: <jwvk5v4c0bh.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Sat, 19 May 2007 11:18:24 -0400)
In article <jwvk5v4c0bh.fsf-monnier+emacs@gnu.org>, Stefan Monnier <monnier@iro.umontreal.ca> writes:
> > There are two bugs with identical structure - one in `skip_chars' and
> > one in `scan_words'.
> I have just installed a patch in EMACS_22_BASE for skip_chars.
Thank you. I've just installed the corresponding change in
emacs-unicode-2.
> As for scan_words, I don't know of such a bug. Also looking at the code,
> I don't see it (not that it proves anything, of course). Could you tell me
> where's the problem in scan_words?
martin rudalics <rudalics@gmx.at> writes:
> With Emacs -Q define foo as
> (defun foo ()
> (interactive)
> (put-text-property (1- (point)) (point) 'syntax-table '(2))
> (setq parse-sexp-lookup-properties t))
> open a text-mode buffer, insert a couple of non-word chars in the
> buffer, leave point after them, and type M-x foo followed by M-b. It
> goes back by _two_ characters instead of one. The attached patch was
> supposed to fix this and the other problem.
I confirmed this bug. It seems that the following single
line change is easier to understand what was wrong, but
Martin's change makes the resulting code easier to read.
*** syntax.c 21 May 2007 21:21:30 +0900 1.205
--- syntax.c 21 May 2007 21:53:50 +0900
***************
*** 1281,1287 ****
if (from == beg)
break;
temp_byte = dec_bytepos (from_byte);
! UPDATE_SYNTAX_TABLE_BACKWARD (from);
ch0 = FETCH_CHAR (temp_byte);
code = SYNTAX (ch0);
if (!(words_include_escapes
--- 1281,1287 ----
if (from == beg)
break;
temp_byte = dec_bytepos (from_byte);
! UPDATE_SYNTAX_TABLE_BACKWARD (from - 1);
ch0 = FETCH_CHAR (temp_byte);
code = SYNTAX (ch0);
if (!(words_include_escapes
---
Kenichi Handa
handa@m17n.org
next prev parent reply other threads:[~2007-05-21 13:01 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-12 10:39 C++ mode and c-beginning-of-current-token Herbert Euler
2007-05-12 13:19 ` Alan Mackenzie
2007-05-12 14:30 ` Herbert Euler
2007-05-12 14:33 ` Herbert Euler
2007-05-12 16:02 ` Herbert Euler
2007-05-12 15:30 ` Herbert Euler
2007-05-12 18:49 ` Alan Mackenzie
2007-05-13 0:51 ` Herbert Euler
2007-05-13 10:01 ` Alan Mackenzie
2007-05-14 2:00 ` Herbert Euler
2007-05-14 8:50 ` Alan Mackenzie
2007-05-14 9:24 ` Herbert Euler
2007-05-14 16:58 ` Stefan Monnier
2007-05-15 3:45 ` Herbert Euler
2007-05-15 6:39 ` martin rudalics
2007-05-16 16:15 ` Stefan Monnier
2007-05-15 13:30 ` Herbert Euler
2007-05-16 8:01 ` Herbert Euler
2007-05-16 8:05 ` Herbert Euler
2007-05-17 2:12 ` Kenichi Handa
2007-05-17 10:18 ` martin rudalics
2007-05-17 12:52 ` Herbert Euler
2007-05-17 13:51 ` martin rudalics
2007-05-17 21:40 ` martin rudalics
2007-05-17 14:32 ` Stefan Monnier
2007-05-17 14:45 ` martin rudalics
2007-05-18 13:00 ` Richard Stallman
2007-05-18 23:39 ` Herbert Euler
2007-05-19 22:31 ` Richard Stallman
2007-05-19 12:59 ` martin rudalics
2007-05-19 15:18 ` Stefan Monnier
2007-05-19 17:48 ` martin rudalics
2007-05-21 13:01 ` Kenichi Handa [this message]
2007-05-21 14:00 ` Stefan Monnier
2007-05-22 1:37 ` Kenichi Handa
2007-05-22 10:26 ` Stefan Monnier
2007-05-22 12:08 ` Kenichi Handa
2007-05-20 6:50 ` Richard Stallman
2007-05-16 9:00 ` martin rudalics
2007-05-16 11:12 ` Herbert Euler
2007-05-16 12:21 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1Hq7WN-00014F-1A@etlken.m17n.org \
--to=handa@m17n.org \
--cc=acm@muc.de \
--cc=emacs-devel@gnu.org \
--cc=herberteuler@hotmail.com \
--cc=monnier@iro.umontreal.ca \
--cc=rms@gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).