From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: [R.Ekker@ai.rug.nl: highlight-changes-rotate-faces sets buffer modified flag] Date: Tue, 08 May 2007 14:09:02 -0400 Message-ID: Reply-To: rms@gnu.org NNTP-Posting-Host: lo.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: sea.gmane.org 1178648006 11017 80.91.229.12 (8 May 2007 18:13:26 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 8 May 2007 18:13:26 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 08 20:13:20 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HlUBb-0002RK-8d for ged-emacs-devel@m.gmane.org; Tue, 08 May 2007 20:13:19 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HlUIh-0006Db-KY for ged-emacs-devel@m.gmane.org; Tue, 08 May 2007 14:20:39 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HlUHS-0005Jt-IZ for emacs-devel@gnu.org; Tue, 08 May 2007 14:19:22 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HlUHR-0005Jh-T1 for emacs-devel@gnu.org; Tue, 08 May 2007 14:19:21 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HlUHR-0005Je-Nv for emacs-devel@gnu.org; Tue, 08 May 2007 14:19:21 -0400 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HlUAK-0002jZ-EU for emacs-devel@gnu.org; Tue, 08 May 2007 14:12:00 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.60) (envelope-from ) id 1HlU7S-0000fM-MQ; Tue, 08 May 2007 14:09:02 -0400 X-detected-kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:70657 Archived-At: I don't know how to use this feature, but looking at the code suggests that this bug still exists. Can anyone verify that? It should be pretty easy to prevent this code from changing the modified flag (and perhaps bind buffer-undo-list to t). I am not sure where the change should be made, though. Would someone familiar with this package please take a look and DTRT? ------- Start of forwarded message ------- X-Spam-Status: No, score=0.0 required=5.0 tests=UNPARSEABLE_RELAY autolearn=failed version=3.1.0 Date: Mon, 7 May 2007 17:30:31 +0200 (CEST) From: Reindert-Jan Ekker To: bug-gnu-emacs@gnu.org MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Subject: highlight-changes-rotate-faces sets buffer modified flag L.S. Running the function highlight-changes-rotate-faces sets the buffer's modified flag. It seems to me that this should not happen, since only some faces are changed. As a workaround, I use the following advice: ;; advice for highlight-changes-rotate-faces ;; so that it does not change the modified flag for the buffer (defadvice highlight-changes-rotate-faces (around around-rotate-faces) (let ((was-modified (buffer-modified-p))) ad-do-it (unless was-modified (set-buffer-modified-p nil)))) (ad-activate 'highlight-changes-rotate-faces) The version string of my emacs: "GNU Emacs 21.3.1 (i386-mingw-nt5.1.2600) of 2004-03-10 on NYAUMO" With kind regards, Reindert-Jan Ekker _______________________________________________ bug-gnu-emacs mailing list bug-gnu-emacs@gnu.org http://lists.gnu.org/mailman/listinfo/bug-gnu-emacs ------- End of forwarded message -------