From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Richard Stallman <rms@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: Subtle bugs in interval code.
Date: Sun, 25 Mar 2007 13:27:22 -0400
Message-ID: <E1HVWV0-0006HU-JS@fencepost.gnu.org>
References: <m3lkhoi3od.fsf@kfs-l.imdomain.dk>
	<E1HUsJG-0002kn-Is@fencepost.gnu.org>
	<m3mz225dch.fsf@kfs-l.imdomain.dk>
Reply-To: rms@gnu.org
NNTP-Posting-Host: lo.gmane.org
Content-Type: text/plain; charset=ISO-8859-15
X-Trace: sea.gmane.org 1174847677 32599 80.91.229.12 (25 Mar 2007 18:34:37 GMT)
X-Complaints-To: usenet@sea.gmane.org
NNTP-Posting-Date: Sun, 25 Mar 2007 18:34:37 +0000 (UTC)
Cc: emacs-devel@gnu.org
To: storm@cua.dk (Kim F. Storm)
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 25 20:34:31 2007
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([199.232.76.165])
	by lo.gmane.org with esmtp (Exim 4.50)
	id 1HVXXu-0008HR-96
	for ged-emacs-devel@m.gmane.org; Sun, 25 Mar 2007 20:34:26 +0200
Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43)
	id 1HVXa3-00083e-C3
	for ged-emacs-devel@m.gmane.org; Sun, 25 Mar 2007 13:36:39 -0500
Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1HVWbY-0007IL-73
	for emacs-devel@gnu.org; Sun, 25 Mar 2007 13:34:08 -0400
Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1HVWbX-0007Hn-Cz
	for emacs-devel@gnu.org; Sun, 25 Mar 2007 13:34:07 -0400
Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1HVWbX-0007He-1b
	for emacs-devel@gnu.org; Sun, 25 Mar 2007 12:34:07 -0500
Original-Received: from fencepost.gnu.org ([199.232.76.164])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <rms@gnu.org>) id 1HVWZ7-0004m2-5J
	for emacs-devel@gnu.org; Sun, 25 Mar 2007 13:31:37 -0400
Original-Received: from rms by fencepost.gnu.org with local (Exim 4.60)
	(envelope-from <rms@gnu.org>)
	id 1HVWV0-0006HU-JS; Sun, 25 Mar 2007 13:27:22 -0400
In-reply-to: <m3mz225dch.fsf@kfs-l.imdomain.dk> (storm@cua.dk)
X-detected-kernel: Linux 2.6, seldom 2.4 (older, 4)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:68538
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/68538>

The patches look good.  Thanks.

    !       if (i0_cdr = XCDR (i0_cdr), !CONSP (i0_cdr))

It is clearer to move the assignment to statement level.
Inside of an if, it could be overlooked.