unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Richard Stallman <rms@gnu.org>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: dann@ics.uci.edu, emacs-devel@gnu.org
Subject: Re: [dalias@aerifal.cx: ansi-term \e[J causes spurious newline [revised report]]
Date: Thu, 22 Mar 2007 01:01:57 -0400	[thread overview]
Message-ID: <E1HUFQz-0006f8-Um@fencepost.gnu.org> (raw)
In-Reply-To: <87zm66o80a.fsf@stupidchicken.com> (message from Chong Yidong on Wed, 21 Mar 2007 12:51:01 -0400)

    Looking through the code, I think the calls to term-unwrap-line should
    be removed.  The note in the docstring of term-erase-in-display that
    it "should only be called when point is at the start of a screen line"
    is also false; this condition generally doesn't hold in situations
    where this function is called, and if we remove the term-unwrap-line
    calls, it's not necessary at all.

    Cursory testing seems to indicate that ansi-term behaves fine without
    the term-unwrap-line calls.

    What do you think?

I do not know that code, but if we do eventually make the change you
recommend, please put in a comment explaining that term-unwrap-line
was formerly called there, and a pointer to the test case for which
that call was removed.  That way, if this change breaks another case,
we will see what to do.

  parent reply	other threads:[~2007-03-22  5:01 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-19 18:10 [dalias@aerifal.cx: ansi-term \e[J causes spurious newline [revised report]] Richard Stallman
2007-03-21 16:51 ` Chong Yidong
2007-03-21 18:40   ` Dan Nicolaescu
2007-03-21 19:16     ` Chong Yidong
2007-03-21 20:16       ` Dan Nicolaescu
2007-03-22  2:36         ` Miles Bader
2007-03-22  3:22           ` Dan Nicolaescu
2007-03-22  3:44             ` Miles Bader
2007-03-22  5:08               ` Dan Nicolaescu
2007-03-22  6:08                 ` Miles Bader
2007-03-22  9:27                 ` Kim F. Storm
2007-03-22 17:06                   ` Dan Nicolaescu
2007-03-22 22:00                     ` Kim F. Storm
2007-03-22  5:01   ` Richard Stallman [this message]
2007-08-03 15:49   ` Dan Nicolaescu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1HUFQz-0006f8-Um@fencepost.gnu.org \
    --to=rms@gnu.org \
    --cc=cyd@stupidchicken.com \
    --cc=dann@ics.uci.edu \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).