unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Richard Stallman <rms@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: emacs-devel@gnu.org
Subject: Re: Info-insert-dir
Date: Mon, 19 Mar 2007 17:57:18 -0400	[thread overview]
Message-ID: <E1HTPqw-00025X-7I@fencepost.gnu.org> (raw)
In-Reply-To: <45FE5CDD.3010909@gmx.at> (message from martin rudalics on Mon, 19 Mar 2007 10:50:21 +0100)

    Probably.  It's a customizable variable and `wid-edit' doesn't even
    check if the user puts valid directory names in there.

It shouldn't check that.  We do not try to stop users from putting
nonexistent directory names into Lisp variables.

	   (unless (file-exists-p default-directory)
	    (setq default-directory (expand-file-name "~/")))

    AFAICT this is the only occurrence of such a test in the entire Emacs
    sources.  It might fail if default-directory equals the name of an
    existing non-directory file - an unlikely case, though.

Perhaps it should verify that this is an existing directory.

      But isn't it
    a bit tedious to search for all occurrences of `call-process' etc?
    Couldn't such a check make it to `call-process', `start-process' ...

It would be incorrect to change call-process to change the default
directory on its own.  Often the execution of a command depends on the
current directory, so that if the current directory is nonexistent, an
error is the right thing.


We could make a subroutine which does this and calls call-process.

  reply	other threads:[~2007-03-19 21:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-16 19:44 Info-insert-dir martin rudalics
     [not found] ` <E1HSuLw-0005So-CU@fencepost.gnu.org>
     [not found]   ` <45FD35C4.7060207@gmx.at>
2007-03-19  5:15     ` Info-insert-dir Richard Stallman
2007-03-19  9:50       ` Info-insert-dir martin rudalics
2007-03-19 21:57         ` Richard Stallman [this message]
2007-03-20  9:56           ` Info-insert-dir martin rudalics
2007-03-21  0:42             ` Info-insert-dir Richard Stallman
2007-03-21  0:42             ` Info-insert-dir Richard Stallman
2007-03-21  7:38               ` Info-insert-dir martin rudalics
2007-03-22  5:01                 ` Info-insert-dir Richard Stallman
2007-03-22  7:19                   ` Info-insert-dir martin rudalics
2007-03-22 22:50                     ` Info-insert-dir Richard Stallman
2007-03-23  9:01                       ` Info-insert-dir martin rudalics
2007-03-23 18:00                         ` Info-insert-dir Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1HTPqw-00025X-7I@fencepost.gnu.org \
    --to=rms@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).