Match color fix

Match color fix

[Juri Linkov]

The most widespread background color to highlight matches nowadays is
yellow.  It is used by many popular programs like Firefox to highlight
search results on the Web page, Web services like Google to highlight
search terms on the result page, and by many other programs and web sites.
It is a good color because it is very noticeable, and at the same time the
text on yellow background is still well readable.  It would be good to use
this background color for the `match' face on the default white background
in Emacs.

The `match' face is a new face in Emacs 22.  The reason why I proposed
its current default color is because it looks well only on my then background
which was darker than the default white background (it was actually
"AntiqueWhite3").  And now after looking at this face on the default
white background I feel guilty for proposing such a bad color.

Fortunately, it is not too late to fix this misfeature before the release
with the following patch:

Index: lisp/replace.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/replace.el,v
retrieving revision 1.253
diff -c -r1.253 replace.el
*** lisp/replace.el	8 Mar 2007 15:17:42 -0000	1.253
--- lisp/replace.el	11 Mar 2007 19:33:11 -0000
***************
*** 849,858 ****
  \f
  (defface match
    '((((class color) (min-colors 88) (background light))
!      :background "Tan")
      (((class color) (min-colors 88) (background dark))
       :background "RoyalBlue3")
!     (((class color) (min-colors 8))
       :background "blue" :foreground "white")
      (((type tty) (class mono))
       :inverse-video t)
--- 849,860 ----
  \f
  (defface match
    '((((class color) (min-colors 88) (background light))
!      :background "yellow")
      (((class color) (min-colors 88) (background dark))
       :background "RoyalBlue3")
!     (((class color) (min-colors 8) (background light))
!      :background "yellow" :foreground "black")
!     (((class color) (min-colors 8) (background dark))
       :background "blue" :foreground "white")
      (((type tty) (class mono))
       :inverse-video t)

-- 
Juri Linkov
http://www.jurta.org/emacs/

Re: Match color fix

[Richard Stallman]

    The most widespread background color to highlight matches nowadays is
    yellow.  It is used by many popular programs like Firefox to highlight
    search results on the Web page, Web services like Google to highlight
    search terms on the result page, and by many other programs and web sites.
    It is a good color because it is very noticeable, and at the same time the
    text on yellow background is still well readable.  It would be good to use
    this background color for the `match' face on the default white background
    in Emacs.

That is good reasoning, so I installed your patch.