unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [david.hansen@physik.fu-berlin.de: WoMan Error with the CVS Manual Page]
@ 2007-03-06 22:36 Richard Stallman
  2007-03-08 22:15 ` Glenn Morris
  0 siblings, 1 reply; 6+ messages in thread
From: Richard Stallman @ 2007-03-06 22:36 UTC (permalink / raw)
  To: emacs-devel

Can someone please fix this, then ack?

------- Start of forwarded message -------
From: David Hansen <david.hansen@physik.fu-berlin.de>
To: emacs-pretest-bug@gnu.org
Organization: disorganized
Date: Tue, 06 Mar 2007 03:26:07 +0100
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: WoMan Error with the CVS Manual Page
X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=failed 
	version=3.0.4


Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

$ emacs -Q

and M-x woman RET cvs (you may have complete to get CVS(1)).

Now scroll down to the "update options" section and further to the
description of the "-C" switch (here it's line 3173).  Woman renders
it as

	-C

	Overwrite locally modified files with clean copies from
	  the repository (the modified file is saved in

	-d

while the stand alone man reader renders it as

       -C

         Overwrite locally modified files with clean copies from the repository
         (the modified file is saved in .#file.revision, however).

       -d

This is

$ cvs --version
Concurrent Versions System (CVS) 1.12.13 (client/server)

from the standard debian unstable package (can send the man page if
needed).

David

If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
/home/dhansen/share/emacs/22.0.95/etc/DEBUG for instructions.


In GNU Emacs 22.0.95.1 (i686-pc-linux-gnu)
 of 2007-03-05 on robotron
X server distributor `The X.Org Foundation', version 11.0.70101000
configured using `configure  '--prefix=/home/dhansen' '--with-x-toolkit=no' '--disable-pop''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: en_US.UTF-8
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8
  default-enable-multibyte-characters: t

Major mode: WoMan

Minor modes in effect:
  shell-dirtrack-mode: t
  erc-menu-mode: t
  erc-ring-mode: t
  erc-pcomplete-mode: t
  erc-netsplit-mode: t
  erc-spelling-mode: t
  erc-truncate-mode: t
  TeX-PDF-mode: t
  jabber-activity-mode: t
  erc-services-mode: t
  erc-autojoin-mode: t
  erc-track-mode: t
  erc-match-mode: t
  erc-button-mode: t
  erc-fill-mode: t
  erc-stamp-mode: t
  erc-smiley-mode: t
  erc-irccontrols-mode: t
  erc-noncommands-mode: t
  erc-readonly-mode: t
  erc-scrolltobottom-mode: t
  which-function-mode: t
  show-paren-mode: t
  iswitchb-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  unify-8859-on-encoding-mode: t
  utf-translate-cjk-mode: t
  auto-compression-mode: t
  line-number-mode: t
  abbrev-mode: 1

Recent input:
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> 
<up> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <return> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <next> <down> <down> <down> <down> <down> <down> 
C-x k <return> C-n C-n C-n C-n C-n C-n C-n C-n C-n 
C-n C-n C-n M-x m a <backspace> C-g C-h RET c v s <return> 
1 <return> <return> <C-tab> C-s - A C-s C-s C-s C-s 
C-s C-x 1 C-l M-x r e p o <tab> r t <tab> e m a <tab> 
<return> b SPC <return>

Recent messages:
CVS process has completed in *cvs*
Quit
Building list of manual directory expansions...
Building completion list of all manual topics...
Making completion list...
uncompressing cvs.1.gz...done
WoMan formatting buffer...done in 2 seconds
Mark saved where search started
Making completion list... [2 times]
Loading emacsbug...done


_______________________________________________
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
------- End of forwarded message -------

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [david.hansen@physik.fu-berlin.de: WoMan Error with the CVS Manual Page]
  2007-03-06 22:36 [david.hansen@physik.fu-berlin.de: WoMan Error with the CVS Manual Page] Richard Stallman
@ 2007-03-08 22:15 ` Glenn Morris
  2007-03-09  5:28   ` David Hansen
  2007-03-09 21:25   ` Richard Stallman
  0 siblings, 2 replies; 6+ messages in thread
From: Glenn Morris @ 2007-03-08 22:15 UTC (permalink / raw)
  To: david.hansen; +Cc: Richard Stallman, emacs-devel


> From: David Hansen <david.hansen@physik.fu-berlin.de>
> Subject: WoMan Error with the CVS Manual Page
> To: emacs-pretest-bug@gnu.org
> Date: Tue, 06 Mar 2007 03:26:07 +0100

Does this patch give good results? I notice several other woman errors
in formatting the cvs man page. This patch at least does not seem to
make those any worse.


Index: woman.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/woman.el,v
retrieving revision 1.53
diff -c -c -w -r1.53 woman.el
*** woman.el	21 Jan 2007 03:53:10 -0000	1.53
--- woman.el	8 Mar 2007 22:13:30 -0000
***************
*** 3284,3290 ****
  	;; Find font requests, paragraph macros and font escapes:
  	(re-search-forward
  	 "^[.'][ \t]*\\(\\(\\ft\\)\\|\\(.P\\)\\)\\|\\(\\\\f\\)" nil 1)
!       (let (font beg notfont)
  	;; Match font indicator and leave point at end of sequence:
  	(cond ((match-string 2)
  	       ;; .ft request found
--- 3284,3290 ----
  	;; Find font requests, paragraph macros and font escapes:
  	(re-search-forward
  	 "^[.'][ \t]*\\(\\(\\ft\\)\\|\\(.P\\)\\)\\|\\(\\\\f\\)" nil 1)
!       (let (font beg notfont fescape)
  	;; Match font indicator and leave point at end of sequence:
  	(cond ((match-string 2)
  	       ;; .ft request found
***************
*** 3299,3305 ****
  	       (setq font 'default))
  	      ((match-string 4)
  	       ;; \f escape found
! 	       (setq beg (match-beginning 0))
  	       (woman-match-name))
  	      (t (setq notfont t)))
  	(if notfont
--- 3299,3306 ----
  	       (setq font 'default))
  	      ((match-string 4)
  	       ;; \f escape found
! 	       (setq beg (match-beginning 0)
!                      fescape t)
  	       (woman-match-name))
  	      (t (setq notfont t)))
  	(if notfont
***************
*** 3321,3326 ****
--- 3322,3334 ----
  	  ;; Delete font control line or escape sequence:
  	  (cond (beg (delete-region beg (point))
  		     (if (eq font 'previous) (setq font previous-font))))
+           ;; Deal with things like \fB.cvsrc\fR at the start of a line.
+           ;; After removing the font control codes, this would
+           ;; otherwise match woman-request-regexp. The "\\&" which is
+           ;; inserted to prevent this is removed by woman2-process-escapes.
+           (and fescape
+                (looking-at "^\\.")
+                (insert "\\&"))
  	  (woman-set-face previous-pos (point) current-font)
  	  (if beg
  	      ;; Explicit font control

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [david.hansen@physik.fu-berlin.de: WoMan Error with the CVS Manual Page]
  2007-03-08 22:15 ` Glenn Morris
@ 2007-03-09  5:28   ` David Hansen
  2007-03-09  9:58     ` Glenn Morris
  2007-03-09 21:25   ` Richard Stallman
  1 sibling, 1 reply; 6+ messages in thread
From: David Hansen @ 2007-03-09  5:28 UTC (permalink / raw)
  To: emacs-devel

On Thu, 08 Mar 2007 17:15:34 -0500 Glenn Morris wrote:

>> From: David Hansen <david.hansen@physik.fu-berlin.de>
>> Subject: WoMan Error with the CVS Manual Page
>> To: emacs-pretest-bug@gnu.org
>> Date: Tue, 06 Mar 2007 03:26:07 +0100
>
> Does this patch give good results? I notice several other woman errors
> in formatting the cvs man page. This patch at least does not seem to
> make those any worse.

This part of the cvs man page is rendered fine now.  I still get one
message in *WoMan-Log* buffer though:

Formatting file /usr/share/man/man1/cvs.1.gz at Fri Mar  9 06:25:17 2007
  **  Undefined string Dt not interpolated!

Don't know if that's bad or not.

David

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [david.hansen@physik.fu-berlin.de: WoMan Error with the CVS Manual Page]
  2007-03-09  5:28   ` David Hansen
@ 2007-03-09  9:58     ` Glenn Morris
  0 siblings, 0 replies; 6+ messages in thread
From: Glenn Morris @ 2007-03-09  9:58 UTC (permalink / raw)
  To: emacs-devel

David Hansen wrote:

> This part of the cvs man page is rendered fine now.  I still get one
> message in *WoMan-Log* buffer though:
>
> Formatting file /usr/share/man/man1/cvs.1.gz at Fri Mar  9 06:25:17 2007
>   **  Undefined string Dt not interpolated!

I think this is OK. The CVS man page has a bug (Dt is indeed
undefined). WoMan logs the error and renders an empty string in the
man page.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [david.hansen@physik.fu-berlin.de: WoMan Error with the CVS Manual Page]
  2007-03-08 22:15 ` Glenn Morris
  2007-03-09  5:28   ` David Hansen
@ 2007-03-09 21:25   ` Richard Stallman
  2007-03-10  4:15     ` Glenn Morris
  1 sibling, 1 reply; 6+ messages in thread
From: Richard Stallman @ 2007-03-09 21:25 UTC (permalink / raw)
  To: Glenn Morris; +Cc: david.hansen, emacs-devel

    Does this patch give good results? I notice several other woman errors
    in formatting the cvs man page. This patch at least does not seem to
    make those any worse.

Can you fix any of those other errors?

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [david.hansen@physik.fu-berlin.de: WoMan Error with the CVS Manual Page]
  2007-03-09 21:25   ` Richard Stallman
@ 2007-03-10  4:15     ` Glenn Morris
  0 siblings, 0 replies; 6+ messages in thread
From: Glenn Morris @ 2007-03-10  4:15 UTC (permalink / raw)
  To: rms; +Cc: david.hansen, emacs-devel

Richard Stallman wrote:

> Can you fix any of those other errors?

I checked in some hacks to handle all the obvious problems. I think
they are mostly due to dodgy ?roff usage in cvs.1, but standalone man
handles them ok.

OT:

woman still does not render the cvs manpage as nicely as man does, IMO.
This is due to the different ways the two programs handle the IP
request. man seems to indent and fill every line of the paragraph;
woman treats the first line specially (no indent, no fill). It's
possible this is what one is supposed to do, but it makes the man page
look worse. Again, maybe this is due to bad ?roff usage in cvs.1.
Anyway, now is definitely not the time to change this.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2007-03-10  4:15 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-06 22:36 [david.hansen@physik.fu-berlin.de: WoMan Error with the CVS Manual Page] Richard Stallman
2007-03-08 22:15 ` Glenn Morris
2007-03-09  5:28   ` David Hansen
2007-03-09  9:58     ` Glenn Morris
2007-03-09 21:25   ` Richard Stallman
2007-03-10  4:15     ` Glenn Morris

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).