* mouse-1-click-in-non-selected-windows
@ 2007-02-28 22:03 Sean O'Rourke
2007-03-05 2:55 ` mouse-1-click-in-non-selected-windows Richard Stallman
0 siblings, 1 reply; 3+ messages in thread
From: Sean O'Rourke @ 2007-02-28 22:03 UTC (permalink / raw)
To: emacs-devel
I believe this change is necessary to make
mouse-1-click-in-non-selected-windows consistent with
mouse-1-click-follows-link when the latter is set to nil (which
is the case later around line 919).
/s
Index: mouse.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/mouse.el,v
retrieving revision 1.312
diff -u -r1.312 mouse.el
--- mouse.el 26 Feb 2007 10:11:34 -0000 1.312
+++ mouse.el 28 Feb 2007 22:00:05 -0000
@@ -834,7 +834,8 @@
at the same position."
(let ((action
(and (or (not (consp pos))
- mouse-1-click-in-non-selected-windows
+ (and mouse-1-click-follows-link
+ mouse-1-click-in-non-selected-windows)
(eq (selected-window) (posn-window pos)))
(or (mouse-posn-property pos 'follow-link)
(key-binding [follow-link] nil t pos)))))
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: mouse-1-click-in-non-selected-windows
2007-02-28 22:03 mouse-1-click-in-non-selected-windows Sean O'Rourke
@ 2007-03-05 2:55 ` Richard Stallman
2007-03-05 17:35 ` mouse-1-click-in-non-selected-windows Sean O'Rourke
0 siblings, 1 reply; 3+ messages in thread
From: Richard Stallman @ 2007-03-05 2:55 UTC (permalink / raw)
To: Sean O'Rourke; +Cc: emacs-devel
I believe this change is necessary to make
mouse-1-click-in-non-selected-windows consistent with
mouse-1-click-follows-link when the latter is set to nil (which
is the case later around line 919).
What evidence is there that this change is needed?
Both of the callers of mouse mouse-on-link-p
test mouse-1-click-follows-link first.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: mouse-1-click-in-non-selected-windows
2007-03-05 2:55 ` mouse-1-click-in-non-selected-windows Richard Stallman
@ 2007-03-05 17:35 ` Sean O'Rourke
0 siblings, 0 replies; 3+ messages in thread
From: Sean O'Rourke @ 2007-03-05 17:35 UTC (permalink / raw)
To: rms; +Cc: emacs-devel
Richard Stallman <rms@gnu.org> writes:
> I believe this change is necessary to make
> mouse-1-click-in-non-selected-windows consistent with
> mouse-1-click-follows-link when the latter is set to nil (which
> is the case later around line 919).
>
> What evidence is there that this change is needed?
> Both of the callers of mouse mouse-on-link-p
> test mouse-1-click-follows-link first.
Sorry to have wasted your time. I ran into an annoying case, in
a GNUS article buffer, of mouse-1-click following a link despite
mouse-1-click-follows-link being nil, and thought this fixed it.
However, widget.el and wid-edit.el are to blame, not
mouse-1-click-in-non-selected-windows; they have their own idea
of what mouse-1 on links should do.
/s
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-03-05 17:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-02-28 22:03 mouse-1-click-in-non-selected-windows Sean O'Rourke
2007-03-05 2:55 ` mouse-1-click-in-non-selected-windows Richard Stallman
2007-03-05 17:35 ` mouse-1-click-in-non-selected-windows Sean O'Rourke
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).