From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Is this tempo.el patch correct? Date: Fri, 02 Mar 2007 18:47:16 -0500 Message-ID: Reply-To: rms@gnu.org NNTP-Posting-Host: lo.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: sea.gmane.org 1172879445 21879 80.91.229.12 (2 Mar 2007 23:50:45 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 2 Mar 2007 23:50:45 +0000 (UTC) Cc: emacs-devel@gnu.org To: davidk@lysator.liu.se Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 03 00:50:39 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HNHWH-0008Et-UY for ged-emacs-devel@m.gmane.org; Sat, 03 Mar 2007 00:50:38 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HNHWH-0006MJ-Hy for ged-emacs-devel@m.gmane.org; Fri, 02 Mar 2007 18:50:37 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HNHUf-0004pk-MC for emacs-devel@gnu.org; Fri, 02 Mar 2007 18:48:57 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HNHUe-0004pK-Sn for emacs-devel@gnu.org; Fri, 02 Mar 2007 18:48:57 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HNHUe-0004pD-LD for emacs-devel@gnu.org; Fri, 02 Mar 2007 18:48:56 -0500 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by monty-python.gnu.org with esmtp (Exim 4.52) id 1HNHUe-0002VG-7b for emacs-devel@gnu.org; Fri, 02 Mar 2007 18:48:56 -0500 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.60) (envelope-from ) id 1HNHT2-0002Xv-My; Fri, 02 Mar 2007 18:47:16 -0500 X-detected-kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:67244 Archived-At: Please tell us whether to install this patch. ------- Start of forwarded message ------- To: emacs-pretest-bug@gnu.org From: Lawrence Mitchell Date: Fri, 02 Mar 2007 14:39:11 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: r> insertion marker not handled correctly in tempo X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=failed version=3.0.4 If you define a tempo template that includes the "r>" insertion marker, attempting to use that template results in an error that the function "r>" is undefined. This bug may be reproduced as follows: emacs -Q Evaluate: (progn (require 'tempo) (tempo-define-template "show-bug" '("Some string" n> (r> "body: "))) (setq debug-on-error t) (tempo-template-show-bug)) The following patch fixes this problem in, I believe, the correct manner: Index: tempo.el =================================================================== RCS file: /sources/emacs/emacs/lisp/tempo.el,v retrieving revision 1.20.6.11 diff -c -r1.20.6.11 tempo.el *** tempo.el 26 Jan 2007 06:15:15 -0000 1.20.6.11 - --- tempo.el 2 Mar 2007 14:36:39 -0000 *************** *** 352,357 **** - --- 352,364 ---- (goto-char tempo-region-stop) (tempo-insert-prompt-compat (cdr element)))) + ((and (consp element) + (eq (car element) 'r>)) (if on-region + (progn + (goto-char tempo-region-stop) + (indent-region (mark) (point) nil)) + (tempo-insert-prompt-compat + (cdr element)))) ((and (consp element) (eq (car element) 's)) (tempo-insert-named (car (cdr element)))) ((and (consp element) Changelog entry: 2007-03-02 Lawrence Mitchell * tempo.el (tempo-insert): Deal with 'r> if it appears specified with a prompt argument. Cheers, Lawrence - -- Lawrence Mitchell _______________________________________________ emacs-pretest-bug mailing list emacs-pretest-bug@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug ------- End of forwarded message -------