From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: convert-standard-filename on w32 does not preserve match-data? Date: Thu, 28 Dec 2006 12:19:00 -0500 Message-ID: References: <4589B680.3080606@student.lu.se> <45928AEE.8030707@gmail.com> Reply-To: rms@gnu.org NNTP-Posting-Host: dough.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: sea.gmane.org 1167329856 20413 80.91.229.10 (28 Dec 2006 18:17:36 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 28 Dec 2006 18:17:36 +0000 (UTC) Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Dec 28 19:17:35 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by dough.gmane.org with esmtp (Exim 4.50) id 1Gzzoo-0007I8-PM for ged-emacs-devel@m.gmane.org; Thu, 28 Dec 2006 19:17:31 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Gzzon-0006Hw-Up for ged-emacs-devel@m.gmane.org; Thu, 28 Dec 2006 13:17:29 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GzzoY-0006GN-LY for emacs-devel@gnu.org; Thu, 28 Dec 2006 13:17:14 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GzzoX-0006FQ-BT for emacs-devel@gnu.org; Thu, 28 Dec 2006 13:17:13 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GzzoW-0006F7-V8 for emacs-devel@gnu.org; Thu, 28 Dec 2006 13:17:13 -0500 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GzyuO-00053w-Jc for emacs-devel@gnu.org; Thu, 28 Dec 2006 12:19:13 -0500 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.60) (envelope-from ) id 1GzyuC-00052C-4v; Thu, 28 Dec 2006 12:19:00 -0500 Original-To: "Lennart Borgman (gmail)" In-reply-to: <45928AEE.8030707@gmail.com> (lennart.borgman@gmail.com) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:64402 Archived-At: The code using convert-standard-filename probably already feels a bit overloaded. convert-standard-filename is an "add on" to what one actually tries to do and it is easily left out. Requiring the coder to also add save-match-data seems like an unnecessary burden in this case and I therefore think that convert-standard-filename should call save-match-data internally. That is how I see it. There will be some cases where for speed it is better not to do save-match-data. But in many cases the cleanliness of adding it is more important than the speed of omitting it.