From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Francesco Potorti` Newsgroups: gmane.emacs.devel Subject: Re: [PATCH, RFC] etags/ctags v22.0.92 break Linux kernel `make TAGS/tags` Date: Thu, 28 Dec 2006 01:10:26 +0100 Message-ID: References: <1166990491.2706.205.camel@localhost.localdomain> <1167158597.2706.224.camel@localhost.localdomain> NNTP-Posting-Host: dough.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE X-Trace: sea.gmane.org 1167264710 27316 80.91.229.10 (28 Dec 2006 00:11:50 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 28 Dec 2006 00:11:50 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Dec 28 01:11:48 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by dough.gmane.org with esmtp (Exim 4.50) id 1Gzis4-00034V-U2 for ged-emacs-devel@m.gmane.org; Thu, 28 Dec 2006 01:11:45 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Gzis4-0002DR-DJ for ged-emacs-devel@m.gmane.org; Wed, 27 Dec 2006 19:11:44 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Gziri-00028T-Vp for emacs-devel@gnu.org; Wed, 27 Dec 2006 19:11:23 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Gzirg-00026g-Oi for emacs-devel@gnu.org; Wed, 27 Dec 2006 19:11:21 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Gzirg-00026U-IG for emacs-devel@gnu.org; Wed, 27 Dec 2006 19:11:20 -0500 Original-Received: from [194.119.192.4] (helo=mx2.isti.cnr.it) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1Gzirg-0000iM-4a for emacs-devel@gnu.org; Wed, 27 Dec 2006 19:11:20 -0500 Original-Received: from conversionlocal.isti.cnr.it by mx.isti.cnr.it (PMDF V6.3-x3 #31251) id <01MB8PC87WTSA0ZROO@mx.isti.cnr.it> for emacs-devel@gnu.org; Thu, 28 Dec 2006 01:10:31 +0100 Original-Received: from tucano.isti.cnr.it (tucano.isti.cnr.it [146.48.81.102]) by mx.isti.cnr.it (PMDF V6.3-x3 #31251) with ESMTPS id <01MB8PC5KV1SA0ZGYZ@mx.isti.cnr.it>; Thu, 28 Dec 2006 01:10:27 +0100 Original-Received: from pot by tucano.isti.cnr.it with local (Exim 4.63) (envelope-from ) id 1Gziqo-0004Ic-NS; Thu, 28 Dec 2006 01:10:26 +0100 In-reply-to: <1167158597.2706.224.camel@localhost.localdomain> Original-To: Don Mullis X-INSM-ip-source: 146.48.81.102 Auth Optional-NoAuth X-fingerprint: 4B02 6187 5C03 D6B1 2E31 7666 09DF 2DC9 BE21 6115 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:64382 Archived-At: >The bug only appears if some `make *config` has succeeded. Try: > >=09make allnoconfig >=09make TAGS > >I have verified that the above shows the bug with 2.6.18 Linux. Okay, I found out why and corrected it. Please try it yourself and l= et me know. Thank you for finding this bug. This is the relevant Changelog entry: 2006-12-28 Francesco Potort=EC =09* etags.c (readline): When creating a relative file name from a =09#line directive, leave the file name alone. The previous =09behaviour was to make it relative to the tags file directory, =09under the hypothesis that the #line directive file name was =09relative to the directory of the tagged file. That hypothesis is =09wrong with Cpp and Lex. and this is the patch: @@ -6285,7 +6285,7 @@ readline (lbp, stream) =09=09 name =3D lbp->buffer + start; =09=09 *endp =3D '\0'; =09=09 canonicalize_filename (name); /* for DOS */ -=09=09 taggedabsname =3D absolute_filename (name, curfdp->infabsdir= ); +=09=09 taggedabsname =3D absolute_filename (name, tagfiledir); =09=09 if (filename_is_absolute (name) =09=09 || filename_is_absolute (curfdp->infname)) =09=09 taggedfname =3D savestr (taggedabsname);