[disumu@x3y2z1.net: URL not following some 302 redirects after recent changes]

[disumu@x3y2z1.net: URL not following some 302 redirects after recent changes]

[Richard Stallman]

Does this still fail?  If so, would someone please fix it?
Please ack when it is fixed.

------- Start of forwarded message -------
Date: Wed, 22 Nov 2006 03:35:17 +0100
From: Diane Murray <disumu@x3y2z1.net>
To: emacs-devel@gnu.org
Subject: URL not following some 302 redirects after recent changes
X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=failed 
	version=3.0.4

Sometime after 2006-10-26 URL redirects stopped working correctly
(Emacs CVS of 2006-09-19 and 2006-10-26 works, 2006-10-31 and
2006-11-19 don't work), perhaps due to changes made in revision 1.36
of url-http.el.

For example, <http://www.cliki.net/cliki> returns the following
headers, but `url-retrieve' runs the callback function instead of
first retrieving the new location:

HTTP/1.0 302 Redirected
Date: Fri, 17 Nov 2006 17:50:59 GMT
Server: Araneida/0.84
Connection: close
Content-Type: text/html
Last-Modified: Fri, 17 Nov 2006 17:50:59 GMT
Location: http://www.cliki.net/CLiki
Pragma: no-cache
Expires: Fri, 30 Oct 1998 14:19:41 GMT

The above-mentioned working versions retrieve the redirected URL
correctly.


_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel
------- End of forwarded message -------

Re: [disumu@x3y2z1.net: URL not following some 302 redirects after recent changes]

[Magnus Henoch]

Richard Stallman <rms@gnu.org> writes:

> Does this still fail?

Yes.

> If so, would someone please fix it?  Please ack when it is fixed.

A clean way to do it is not immediately obvious to me.  The problem is
that url-http-async-sentinel tries to change the sentinel, which fails
since the sentinel of a process is "bound" to nil during sentinel
execution (which I had forgotten when I wrote this function in the
first place).  I could create a buffer-local variable that tells the
filter function to change the sentinel, but is there a better way to
solve this?

Magnus

Re: [disumu@x3y2z1.net: URL not following some 302 redirects after recent changes]

[Stefan Monnier]

>> Does this still fail?
> Yes.
>> If so, would someone please fix it?  Please ack when it is fixed.
> A clean way to do it is not immediately obvious to me.  The problem is
> that url-http-async-sentinel tries to change the sentinel, which fails
> since the sentinel of a process is "bound" to nil during sentinel
> execution (which I had forgotten when I wrote this function in the
> first place).  I could create a buffer-local variable that tells the
> filter function to change the sentinel, but is there a better way to
> solve this?

Or have the sentinel be a function that calls another function (this one
stored in a buffer-local var, or in the process-plist),


        Stefan

Re: [disumu@x3y2z1.net: URL not following some 302 redirects after recent changes]

[Richard Stallman]

      The problem is
    that url-http-async-sentinel tries to change the sentinel, which fails
    since the sentinel of a process is "bound" to nil during sentinel
    execution (which I had forgotten when I wrote this function in the
    first place).

The technique of changing the sentinel from within the sentinel seems
somewhat kludgy.  So here is another idea.

url-http-async-sentinel could instead set a flag, so that when it is
called again and sees that flag set, it will call
url-http-end-of-document-sentinel.

Would that work?