etags comma on emacs DEFUNs

etags comma on emacs DEFUNs

[Kevin Ryde]

[-- Attachment #1: Type: text/plain, Size: 698 bytes --]

It looks like etags puts a comma on the end of the lisp name of an
emacs DEFUN.  Eg. the foo.c below which is a copy of car-safe from
src/data.c,

	etags foo.c

creates a TAGS file with (expanding ^? and ^A for the sake of mail),

	foo.c,44
	DEFUN ("car-safe", Fcar_safe,^?car-safe,^A1,0

and indeed in emacs

	M-x visit-tags-table Ret
	M-. Tab

offers a sole completion

	car-safe,

where I didn't expect to see a "," on the end.  Seems harmless most of
the time because you can type car-safe and M-. will jump to a partial
match, but it's not intended is it?

It looks like whatever char is after Fcar_safe is included in the tag,
you can insert a space there in the source and it goes through.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: foo.c --]
[-- Type: text/x-csrc, Size: 201 bytes --]

DEFUN ("car-safe", Fcar_safe, Scar_safe, 1, 1, 0,
       doc: /* Return the car of OBJECT if it is a cons cell, or else nil.  */)
     (object)
     Lisp_Object object;
{
  return CAR_SAFE (object);
}

[-- Attachment #3: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: etags comma on emacs DEFUNs

[Francesco Potorti`]

>It looks like etags puts a comma on the end of the lisp name of an
>emacs DEFUN.  Eg. the foo.c below which is a copy of car-safe from
>src/data.c,
>
>	etags foo.c
>
>creates a TAGS file with (expanding ^? and ^A for the sake of mail),
>
>	foo.c,44
>	DEFUN ("car-safe", Fcar_safe,^?car-safe,^A1,0

>where I didn't expect to see a "," on the end.  Seems harmless most of
>the time because you can type car-safe and M-. will jump to a partial
>match, but it's not intended is it?

No.  I just checked old versions, and it's a long-standing bug.  I'll
try to come up with a solution soon.

Re: etags comma on emacs DEFUNs

[Francesco Potorti`]

Bug corrected and probable bug in etags.el.

>It looks like etags puts a comma on the end of the lisp name of an
>emacs DEFUN.  Eg. the foo.c below which is a copy of car-safe from
>src/data.c,
>
>	etags foo.c
>
>creates a TAGS file with (expanding ^? and ^A for the sake of mail),
>
>	foo.c,44
>	DEFUN ("car-safe", Fcar_safe,^?car-safe,^A1,0

>where I didn't expect to see a "," on the end.  Seems harmless most of
>the time because you can type car-safe and M-. will jump to a partial
>match, but it's not intended is it?

Corrected.  Where the length was corrected for DEFUN, a spurious line
(a leftover of old code) undid the change.  I just checked in the
correct version.  Thanks for spotting this.