From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: [mmaug@yahoo.com: font-lock applied to comint prompts] Date: Fri, 01 Dec 2006 08:37:03 -0500 Message-ID: References: <7630872.post@talk.nabble.com> Reply-To: rms@gnu.org NNTP-Posting-Host: main.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: sea.gmane.org 1164980271 11311 80.91.229.2 (1 Dec 2006 13:37:51 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 1 Dec 2006 13:37:51 +0000 (UTC) Cc: Emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 01 14:37:50 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Gq8aB-000786-3M for ged-emacs-devel@m.gmane.org; Fri, 01 Dec 2006 14:37:40 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Gq8aA-0001TV-MI for ged-emacs-devel@m.gmane.org; Fri, 01 Dec 2006 08:37:38 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Gq8Ze-0001Ar-96 for emacs-devel@gnu.org; Fri, 01 Dec 2006 08:37:06 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Gq8Zd-00019S-0z for Emacs-devel@gnu.org; Fri, 01 Dec 2006 08:37:05 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Gq8Zc-000195-QE for Emacs-devel@gnu.org; Fri, 01 Dec 2006 08:37:04 -0500 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.52) id 1Gq8Zc-0001Ec-QP for Emacs-devel@gnu.org; Fri, 01 Dec 2006 08:37:04 -0500 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.52) id 1Gq8Zb-0007lC-Gb; Fri, 01 Dec 2006 08:37:03 -0500 Original-To: Michael Mauger In-reply-to: <7630872.post@talk.nabble.com> (message from Michael Mauger on Thu, 30 Nov 2006 16:02:48 -0800 (PST)) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:63189 Archived-At: There reason for the font-lock-face property is so that it won't actually appear on the display unless Font-Lock mode is enabled. In effect, it is a way to "manually" implement fotification in a certain major mode. Your change would override this and display the face even if Font-Lock mode is disabled. That's not correct. Since comint uses font-lock-face instead of specifying fontification rules, it surprises me that the `face' property is placed on anything. Maybe that comes from Shell mode, from shell-font-lock-keywords. That seems like an inconsistency, somewhat. Maybe that is the cause of the problem. If you can put the `face' property on the overlay only when the text it is over has a `face' property, then I think it will be correct, because when Font-Lock is off it won't do anything. Could you do it that way?