From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: [seltenreich@gmx.de: Patch: make navigation work as documented in easy-mmode derived modes] Date: Tue, 28 Nov 2006 12:48:56 -0500 Message-ID: Reply-To: rms@gnu.org NNTP-Posting-Host: main.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: sea.gmane.org 1164736201 24998 80.91.229.2 (28 Nov 2006 17:50:01 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 28 Nov 2006 17:50:01 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 28 18:49:57 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Gp75F-0004aJ-3K for ged-emacs-devel@m.gmane.org; Tue, 28 Nov 2006 18:49:29 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Gp75E-0004DP-G7 for ged-emacs-devel@m.gmane.org; Tue, 28 Nov 2006 12:49:28 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Gp74l-0003xP-Pd for emacs-devel@gnu.org; Tue, 28 Nov 2006 12:48:59 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Gp74k-0003vd-Ng for emacs-devel@gnu.org; Tue, 28 Nov 2006 12:48:59 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Gp74k-0003v8-E4 for emacs-devel@gnu.org; Tue, 28 Nov 2006 12:48:58 -0500 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.52) id 1Gp74k-0003F8-4p for emacs-devel@gnu.org; Tue, 28 Nov 2006 12:48:58 -0500 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.52) id 1Gp74i-0006X8-Ts; Tue, 28 Nov 2006 12:48:56 -0500 Original-To: emacs-devel@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:62972 Archived-At: Would someone please install this, then ack? ------- Start of forwarded message ------- From: Andreas Seltenreich To: emacs-devel@gnu.org Date: Mon, 27 Nov 2006 16:44:19 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Patch: make navigation work as documented in easy-mmode derived modes X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=failed version=3.0.4 I just noticed that prefix args didn't work when navigating in diff-mode, contrary to the docstrings of the functions. The attached patch fixes it for me. regards, andreas Index: lisp/ChangeLog =================================================================== RCS file: /sources/emacs/emacs/lisp/ChangeLog,v retrieving revision 1.10357 diff -u -0 -r1.10357 ChangeLog - --- lisp/ChangeLog 27 Nov 2006 14:35:47 -0000 1.10357 +++ lisp/ChangeLog 27 Nov 2006 15:21:37 -0000 @@ -0,0 +1,6 @@ +2006-11-27 Andreas Seltenreich + + * emacs-lisp/easy-mmode.el (easy-mmode-define-navigation): Fix + interactive spec of the functions getting defined to make them + work as documented. + Index: lisp/emacs-lisp/easy-mmode.el =================================================================== RCS file: /sources/emacs/emacs/lisp/emacs-lisp/easy-mmode.el,v retrieving revision 1.78 diff -u -r1.78 easy-mmode.el - --- lisp/emacs-lisp/easy-mmode.el 31 Aug 2006 23:14:26 -0000 1.78 +++ lisp/emacs-lisp/easy-mmode.el 27 Nov 2006 15:22:45 -0000 @@ -500,7 +500,7 @@ ,(concat "^No \\(previous\\|next\\) " (regexp-quote name))) (defun ,next-sym (&optional count) ,(format "Go to the next COUNT'th %s." name) - - (interactive) + (interactive "p") (unless count (setq count 1)) (if (< count 0) (,prev-sym (- count)) (if (looking-at ,re) (setq count (1+ count))) @@ -523,7 +523,7 @@ (put ',next-sym 'definition-name ',base) (defun ,prev-sym (&optional count) ,(format "Go to the previous COUNT'th %s" (or name base-name)) - - (interactive) + (interactive "p") (unless count (setq count 1)) (if (< count 0) (,next-sym (- count)) (let (was-narrowed) _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-devel ------- End of forwarded message -------