From: Richard Stallman <rms@gnu.org>
Subject: [seltenreich@gmx.de: Patch: make navigation work as documented in easy-mmode derived modes]
Date: Tue, 28 Nov 2006 12:48:56 -0500 [thread overview]
Message-ID: <E1Gp74i-0006X8-Ts@fencepost.gnu.org> (raw)
Would someone please install this, then ack?
------- Start of forwarded message -------
From: Andreas Seltenreich <seltenreich@gmx.de>
To: emacs-devel@gnu.org
Date: Mon, 27 Nov 2006 16:44:19 +0100
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Patch: make navigation work as documented in easy-mmode derived
modes
X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=failed
version=3.0.4
I just noticed that prefix args didn't work when navigating in
diff-mode, contrary to the docstrings of the functions.
The attached patch fixes it for me.
regards,
andreas
Index: lisp/ChangeLog
===================================================================
RCS file: /sources/emacs/emacs/lisp/ChangeLog,v
retrieving revision 1.10357
diff -u -0 -r1.10357 ChangeLog
- --- lisp/ChangeLog 27 Nov 2006 14:35:47 -0000 1.10357
+++ lisp/ChangeLog 27 Nov 2006 15:21:37 -0000
@@ -0,0 +1,6 @@
+2006-11-27 Andreas Seltenreich <uwi7@rz.uni-karlsruhe.de>
+
+ * emacs-lisp/easy-mmode.el (easy-mmode-define-navigation): Fix
+ interactive spec of the functions getting defined to make them
+ work as documented.
+
Index: lisp/emacs-lisp/easy-mmode.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/emacs-lisp/easy-mmode.el,v
retrieving revision 1.78
diff -u -r1.78 easy-mmode.el
- --- lisp/emacs-lisp/easy-mmode.el 31 Aug 2006 23:14:26 -0000 1.78
+++ lisp/emacs-lisp/easy-mmode.el 27 Nov 2006 15:22:45 -0000
@@ -500,7 +500,7 @@
,(concat "^No \\(previous\\|next\\) " (regexp-quote name)))
(defun ,next-sym (&optional count)
,(format "Go to the next COUNT'th %s." name)
- - (interactive)
+ (interactive "p")
(unless count (setq count 1))
(if (< count 0) (,prev-sym (- count))
(if (looking-at ,re) (setq count (1+ count)))
@@ -523,7 +523,7 @@
(put ',next-sym 'definition-name ',base)
(defun ,prev-sym (&optional count)
,(format "Go to the previous COUNT'th %s" (or name base-name))
- - (interactive)
+ (interactive "p")
(unless count (setq count 1))
(if (< count 0) (,next-sym (- count))
(let (was-narrowed)
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel
------- End of forwarded message -------
next reply other threads:[~2006-11-28 17:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-28 17:48 Richard Stallman [this message]
2006-11-28 19:23 ` [seltenreich@gmx.de: Patch: make navigation work as documented in easy-mmode derived modes] Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1Gp74i-0006X8-Ts@fencepost.gnu.org \
--to=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).