From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: Patch: Syntax and Hard Newlines Date: Thu, 16 Nov 2006 10:01:35 -0500 Message-ID: References: Reply-To: rms@gnu.org NNTP-Posting-Host: main.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: sea.gmane.org 1163689494 21051 80.91.229.2 (16 Nov 2006 15:04:54 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 16 Nov 2006 15:04:54 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 16 16:04:51 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Gkikw-0004j8-Ry for ged-emacs-devel@m.gmane.org; Thu, 16 Nov 2006 16:02:23 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Gkikv-0007JY-Tt for ged-emacs-devel@m.gmane.org; Thu, 16 Nov 2006 10:02:21 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GkikE-00074P-4O for emacs-devel@gnu.org; Thu, 16 Nov 2006 10:01:38 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GkikD-000743-D6 for emacs-devel@gnu.org; Thu, 16 Nov 2006 10:01:37 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GkikD-000740-9e for emacs-devel@gnu.org; Thu, 16 Nov 2006 10:01:37 -0500 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GkikD-0004El-0z for emacs-devel@gnu.org; Thu, 16 Nov 2006 10:01:37 -0500 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34) id 1GkikB-0003Pw-F7; Thu, 16 Nov 2006 10:01:35 -0500 Original-To: bojohan+news@dd.chalmers.se (Johan =?utf-8?Q?Bockg=C3=A5rd?=) In-reply-to: (bojohan+news@dd.chalmers.se) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:62381 Archived-At: However, unlike `assoc' which returns the matching cons, `assoc-default' returns the cdr. In the code in question it is always nil. Does this code work right? *** bytecomp.el 08 Jul 2006 16:59:45 -0400 2.186 --- bytecomp.el 16 Nov 2006 08:24:45 -0500 *************** *** 2864,2871 **** (defmacro byte-compile-get-constant (const) `(or (if (stringp ,const) ! (assoc-default ,const byte-compile-constants ! 'equal-including-properties nil) (assq ,const byte-compile-constants)) (car (setq byte-compile-constants (cons (list ,const) byte-compile-constants))))) --- 2864,2875 ---- (defmacro byte-compile-get-constant (const) `(or (if (stringp ,const) ! ;; In a string constant, treat properties as significant. ! (let (result) ! (dolist (elt byte-compile-constants) ! (if (equal-including-properties (car elt) ,const) ! (setq result elt))) ! result) (assq ,const byte-compile-constants)) (car (setq byte-compile-constants (cons (list ,const) byte-compile-constants)))))