From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Richard Stallman <rms@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: Patch: Syntax and Hard Newlines
Date: Mon, 13 Nov 2006 15:15:49 -0500
Message-ID: <E1GjiDd-0005Re-AT@fencepost.gnu.org>
References: <BAY112-F223EDC2150F1D0DB1C941EDAF40@phx.gbl>
Reply-To: rms@gnu.org
NNTP-Posting-Host: main.gmane.org
Content-Type: text/plain; charset=ISO-8859-15
X-Trace: sea.gmane.org 1163449197 1668 80.91.229.2 (13 Nov 2006 20:19:57 GMT)
X-Complaints-To: usenet@sea.gmane.org
NNTP-Posting-Date: Mon, 13 Nov 2006 20:19:57 +0000 (UTC)
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 13 21:19:50 2006
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([199.232.76.165])
	by ciao.gmane.org with esmtp (Exim 4.43)
	id 1GjiHN-0007FS-DS
	for ged-emacs-devel@m.gmane.org; Mon, 13 Nov 2006 21:19:41 +0100
Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43)
	id 1GjiHM-0003UW-LP
	for ged-emacs-devel@m.gmane.org; Mon, 13 Nov 2006 15:19:40 -0500
Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1GjiDe-0006lZ-Hc
	for emacs-devel@gnu.org; Mon, 13 Nov 2006 15:15:50 -0500
Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1GjiDe-0006kj-0K
	for emacs-devel@gnu.org; Mon, 13 Nov 2006 15:15:50 -0500
Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1GjiDd-0006kL-Qx
	for emacs-devel@gnu.org; Mon, 13 Nov 2006 15:15:49 -0500
Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org)
	by monty-python.gnu.org with esmtp (Exim 4.52) id 1GjiDd-0005Rs-SI
	for emacs-devel@gnu.org; Mon, 13 Nov 2006 15:15:49 -0500
Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34)
	id 1GjiDd-0005Re-AT; Mon, 13 Nov 2006 15:15:49 -0500
Original-To: "Herbert Euler" <herberteuler@hotmail.com>
Original-To: herberteuler@hotmail.com, emacs-devel@gnu.org
In-reply-to: <BAY112-F223EDC2150F1D0DB1C941EDAF40@phx.gbl>
	(herberteuler@hotmail.com)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:62244
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/62244>

    +  skip_soft_newlines = !NILP (Fsymbol_value
    +                              (intern
    +                               ("use-hard-newlines")));
    +

It would look nicer to break the line like this:

    +  skip_soft_newlines
    +    = !NILP (Fsymbol_value (intern ("use-hard-newlines")));
    +

However, if C code is going to examine the value of that variable 
frequently, it would be more efficient to make it a C-level
variable defined with DEFVAR_PER_BUFFER in buffer.c.