From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: [mark@mcs.vuw.ac.nz: sort-columns fails on NetBSD] Date: Fri, 03 Nov 2006 02:07:26 -0500 Message-ID: Reply-To: rms@gnu.org NNTP-Posting-Host: main.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: sea.gmane.org 1162537737 29537 80.91.229.2 (3 Nov 2006 07:08:57 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 3 Nov 2006 07:08:57 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 03 08:08:56 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GftAe-00019t-IU for ged-emacs-devel@m.gmane.org; Fri, 03 Nov 2006 08:08:56 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GftAe-0001Mt-19 for ged-emacs-devel@m.gmane.org; Fri, 03 Nov 2006 02:08:56 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Gft9G-0007Eh-KR for emacs-devel@gnu.org; Fri, 03 Nov 2006 02:07:31 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Gft9F-0007Cs-AV for emacs-devel@gnu.org; Fri, 03 Nov 2006 02:07:29 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Gft9E-0007Ch-Ul for emacs-devel@gnu.org; Fri, 03 Nov 2006 02:07:29 -0500 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.52) id 1Gft9E-0007Lt-KV for emacs-devel@gnu.org; Fri, 03 Nov 2006 02:07:28 -0500 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34) id 1Gft9C-0004Nx-7S; Fri, 03 Nov 2006 02:07:26 -0500 Original-To: emacs-devel@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:61664 Archived-At: Would someone please install this tiny change, plus a comment explaining why? Please also thank him, then ack. ------- Start of forwarded message ------- From: Mark Davies To: bug-gnu-emacs@gnu.org Date: Thu, 2 Nov 2006 23:11:38 +1300 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline Subject: sort-columns fails on NetBSD X-Spam-Status: No, score=0.1 required=5.0 tests=FORGED_RCVD_HELO autolearn=failed version=3.0.4 The sort program on NetBSD objects if the field separator is set to the same value as the record separator. (sort-columns) tries to set it that way so that the whole line is in the same field. However the sort-columns code already makes sure there are no tabs in the region being worked on so we can have the same effect by setting the field separator to tab. Patch is below. cheers mark - --- lisp/sort.el.orig 2006-04-04 13:21:26.000000000 +1200 +++ lisp/sort.el @@ -506,7 +506,7 @@ Use \\[untabify] to convert tabs to spac ;; Do not use it if there are any non-font-lock properties ;; in the region, since the sort utility would lose the ;; properties. - - (let ((sort-args (list (if reverse "-rt\n" "-t\n") + (let ((sort-args (list (if reverse "-rt\t" "-t\t") (format "-k1.%d,1.%d" (1+ col-start) (1+ col-end))))) _______________________________________________ bug-gnu-emacs mailing list bug-gnu-emacs@gnu.org http://lists.gnu.org/mailman/listinfo/bug-gnu-emacs ------- End of forwarded message -------