unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Richard Stallman <rms@gnu.org>
Subject: [mark@mcs.vuw.ac.nz: sort-columns fails on NetBSD]
Date: Fri, 03 Nov 2006 02:07:26 -0500	[thread overview]
Message-ID: <E1Gft9C-0004Nx-7S@fencepost.gnu.org> (raw)

Would someone please install this tiny change,
plus a comment explaining why?
Please also thank him, then ack.

------- Start of forwarded message -------
From: Mark Davies <mark@mcs.vuw.ac.nz>
To: bug-gnu-emacs@gnu.org
Date: Thu, 2 Nov 2006 23:11:38 +1300
MIME-Version: 1.0
Content-Type: text/plain;
  charset="us-ascii"
Content-Disposition: inline
Subject: sort-columns fails on NetBSD
X-Spam-Status: No, score=0.1 required=5.0 tests=FORGED_RCVD_HELO 
	autolearn=failed version=3.0.4

The sort program on NetBSD objects if the field separator is set to 
the same value as the record separator.  (sort-columns) tries to set 
it that way so that the whole line is in the same field.  However the 
sort-columns code already makes sure there are no tabs in the region 
being worked on so we can have the same effect by setting the field 
separator to tab.

Patch is below.

cheers
mark


- --- lisp/sort.el.orig	2006-04-04 13:21:26.000000000 +1200
+++ lisp/sort.el
@@ -506,7 +506,7 @@ Use \\[untabify] to convert tabs to spac
 	  ;; Do not use it if there are any non-font-lock properties
 	  ;; in the region, since the sort utility would lose the
 	  ;; properties.
- -	  (let ((sort-args (list (if reverse "-rt\n" "-t\n")
+	  (let ((sort-args (list (if reverse "-rt\t" "-t\t")
 				 (format "-k1.%d,1.%d"
 					 (1+ col-start)
 					 (1+ col-end)))))


_______________________________________________
bug-gnu-emacs mailing list
bug-gnu-emacs@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-gnu-emacs
------- End of forwarded message -------

             reply	other threads:[~2006-11-03  7:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-03  7:07 Richard Stallman [this message]
2006-11-03 14:43 ` [mark@mcs.vuw.ac.nz: sort-columns fails on NetBSD] Ramprasad

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1Gft9C-0004Nx-7S@fencepost.gnu.org \
    --to=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).