From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kenichi Handa Newsgroups: gmane.emacs.devel Subject: Re: emacs-unicode-2: global-auto-revert-mode doesn't work properly Date: Mon, 23 Oct 2006 22:04:57 +0900 Message-ID: References: <87u06xov1q.fsf@www.williamxu.com> <87hd2ua7gi.fsf@williamxwl.com> <87k67jzvh3.fsf@www.williamxu.com> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.3 - "Ushinoya") Content-Type: text/plain; charset=US-ASCII X-Trace: sea.gmane.org 1161608702 2891 80.91.229.2 (23 Oct 2006 13:05:02 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 23 Oct 2006 13:05:02 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 23 15:04:57 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GbzU6-0002GE-AI for ged-emacs-devel@m.gmane.org; Mon, 23 Oct 2006 15:04:54 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GbzU5-0004Nt-R2 for ged-emacs-devel@m.gmane.org; Mon, 23 Oct 2006 09:04:53 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GbzTR-0004BA-Kt for emacs-devel@gnu.org; Mon, 23 Oct 2006 09:04:13 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GbzTM-00047M-5e for emacs-devel@gnu.org; Mon, 23 Oct 2006 09:04:12 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GbzTL-000473-Qx for emacs-devel@gnu.org; Mon, 23 Oct 2006 09:04:07 -0400 Original-Received: from [150.29.246.133] (helo=mx1.aist.go.jp) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GbzTL-0002EI-50 for emacs-devel@gnu.org; Mon, 23 Oct 2006 09:04:07 -0400 Original-Received: from smtp1.aist.go.jp ([150.29.246.12]) by mx1.aist.go.jp with ESMTP id k9ND40sY028266; Mon, 23 Oct 2006 22:04:01 +0900 (JST) env-from (handa@m17n.org) Original-Received: by smtp1.aist.go.jp with ESMTP id k9ND40j8026158; Mon, 23 Oct 2006 22:04:00 +0900 (JST) env-from (handa@m17n.org) Original-Received: from handa by etlken with local (Exim 3.36 #1 (Debian)) id 1GbzU9-0003Vi-00; Mon, 23 Oct 2006 22:04:57 +0900 Original-To: William Xu In-reply-to: <87k67jzvh3.fsf@www.williamxu.com> (message from William Xu on Wed, 14 Jun 2006 22:02:16 +0800) User-Agent: SEMI/1.14.3 (Ushinoya) FLIM/1.14.2 (Yagi-Nishiguchi) APEL/10.2 Emacs/22.0.50 (i686-pc-linux-gnu) MULE/5.0 (SAKAKI) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:61043 Archived-At: I've just reached to my todo-list entry about this matter. In article <87k67jzvh3.fsf@www.williamxu.com>, William Xu writes: > Kenichi Handa writes: > > Ah, I found that this bug happens when you insert non-ASCII > > characters, > Smart guess ! But seems it makes no difference here.. > > and I found the reason why that causes the > > problem only in emacs-unicode-2 (difference in REPLACE > > handling in Finsert_file_contents; HEAD uses insert_1 but > > emacs-unicode-2 uses insert_from_buffer). I'm now working > > on fixing it. Please wait for a while. > Still progress though ! :-) insert_1 can be called with the arg PREPARE zero, but as insert_from_buffer and insert_from_buffer_1 don't have such an arg, prepare_to_modify_buffer is called unconditionally, which leads to the call of ask-user-about-supersession-threat, which makes global-auto-revert-mode don't work. I've fixed that by binding buffer-file-name to nil temporarily. --- Kenichi Handa handa@m17n.org