unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [PATCH] Unbreak `make install' in leim/ when leim's ${INSTALLDIR} doesn't exist
@ 2006-10-11 23:22 Giorgos Keramidas
  2006-10-12  0:31 ` Giorgos Keramidas
  2006-10-12  5:59 ` Kenichi Handa
  0 siblings, 2 replies; 9+ messages in thread
From: Giorgos Keramidas @ 2006-10-11 23:22 UTC (permalink / raw)


The current `make install' target of the leim/ subdirectory has a subtle
problem when ${prefix}/share/emacs/22.0.50/leim does not exist at all.

After `make bootstrap' completes, running `make install' in leim/ fails
with the following error on a FreeBSD and a Solaris system here:

,----------------------------------------------------------------
| # make install
| if [ -d /opt/local/share/emacs/22.0.50/leim ] && [ x`(cd /opt/local/share/emacs/22.0.50/leim && /bin/pwd)` != x`(/bin/pwd)` ] ; then \
|   if [ -d /opt/local/share/emacs/22.0.50/leim ] ; then \
|     rm -rf /opt/local/share/emacs/22.0.50/leim/leim-list.el; \
|     rm -rf /opt/local/share/emacs/22.0.50/leim/quail /opt/local/share/emacs/22.0.50/leim/ja-dic ; \
|   else \
|     /home/keramida/tmp/emacs/leim/../mkinstalldirs /opt/local/share/emacs/22.0.50/leim; \
|   fi; \
|   echo "Copying leim files to /opt/local/share/emacs/22.0.50/leim ..." ; \
|   if [ x`(cd /home/keramida/tmp/emacs/leim && /bin/pwd)` = x`(/bin/pwd)` ] ; then \
|     tar -chf - leim-list.el quail ja-dic \
|         | (cd /opt/local/share/emacs/22.0.50/leim; umask 0; tar -xvf - && cat > /dev/null) ;\
|   else \
|     tar -chf - leim-list.el quail \
|         | (cd /opt/local/share/emacs/22.0.50/leim; umask 0; tar -xvf - && cat > /dev/null) ;\
|     cd /home/keramida/tmp/emacs/leim; \
|     tar -chf - quail/* ja-dic \
|         | (cd /opt/local/share/emacs/22.0.50/leim; umask 0; tar -xvf - && cat > /dev/null) ;\
|   fi; \ 
|   rm -rf /opt/local/share/emacs/22.0.50/leim/CVS        /opt/local/share/emacs/22.0.50/leim/*/CVS; \
|   rm -f  /opt/local/share/emacs/22.0.50/leim/.cvsignore /opt/local/share/emacs/22.0.50/leim/*/.cvsignore; \
|   rm -f  /opt/local/share/emacs/22.0.50/leim/.arch-inventory /opt/local/share/emacs/22.0.50/leim/*/.arch-inventory; \
|   rm -f  /opt/local/share/emacs/22.0.50/leim/\#*        /opt/local/share/emacs/22.0.50/leim/*/\#* ; \
|   rm -f  /opt/local/share/emacs/22.0.50/leim/.\#*       /opt/local/share/emacs/22.0.50/leim/*/.\#* ; \
|   rm -f  /opt/local/share/emacs/22.0.50/leim/*~         /opt/local/share/emacs/22.0.50/leim/*/*~ ; \
|   rm -f  /opt/local/share/emacs/22.0.50/leim/*.orig     /opt/local/share/emacs/22.0.50/leim/*/*.orig ; \
| else true; fi
| unset CDPATH; \
| if [ -n "/usr/bin/gzip" ]; \
| then \
|    echo "Compressing *.el ..." ; \
|    (cd /opt/local/share/emacs/22.0.50/leim; for f in `find . -name "*.elc" -print`; do \
|         /usr/bin/gzip -9n `echo $f|sed 's/.elc$/.el/'` ; \
|     done) \
| else true; fi
| Compressing *.el ...
| sh: /opt/local/share/emacs/22.0.50/leim: does not exist
| *** Error code 1 (ignored)
| chmod -R a+r /opt/local/share/emacs/22.0.50/leim
| chmod: WARNING: can't access /opt/local/share/emacs/22.0.50/leim
| *** Error code 1 (ignored)
| # 
`----------------------------------------------------------------

The following patch fixes this.  The patch also contains the commit log
from the local tree I used for testing the fix.  Feel free to reuse it,
if it looks like a useful commit log.

--- patch start -------------------------------------------------
# HG changeset patch
# User George Keramidas <gkeramidas@bytemobile.com>
# Date 1160608725 -10800
# Node ID 549c434ebfb50d1a4ca241c8498522c4660c9428
# Parent  34e5fff7519a59470fb437d5eb0a5421e9639e40
Unbreak `make install' in leim/ when leim's ${INSTALLDIR} doesn't exist.

What was happening with the old shell script called by the `install'
target was kind of tricky.  The command:

    if [ x`(cd ${INSTALLDIR} && /bin/pwd)` != x`(/bin/pwd)` ] ; then
      if [ -d ${INSTALLDIR} ] ; then \

contains a backquoted `cd' command into a directory which may not exist.
This causes the /bin/sh shell on Solaris (possibly other systems too),
to abort the entire if-then compound statement, because the `cd' command
fails before the if-then statement has a chance to run at all (i.e. at
backquote-expansion time).

Switching the order of the two if-then checks ensures that `cd' will
only run if ${INSTALLDIR} *really* exists, and `make install' in leim/
works again.

diff -r 34e5fff7519a -r 549c434ebfb5 leim/Makefile.in
*** a/leim/Makefile.in	Wed Oct 11 18:10:15 2006 +0300
--- b/leim/Makefile.in	Thu Oct 12 02:18:45 2006 +0300
***************
*** 216,247 ****
  	sed -n '/^[^;]/ p' < ${srcdir}/leim-ext.el >> $@
  
  install: all
! 	if [ x`(cd ${INSTALLDIR} && /bin/pwd)` != x`(/bin/pwd)` ] ; then \
! 	  if [ -d ${INSTALLDIR} ] ; then \
  	    rm -rf ${INSTALLDIR}/leim-list.el; \
  	    rm -rf ${INSTALLDIR}/quail ${INSTALLDIR}/ja-dic ; \
! 	  else \
! 	    ${srcdir}/${dot}${dot}/mkinstalldirs ${INSTALLDIR}; \
! 	  fi; \
! 	  echo "Copying leim files to ${INSTALLDIR} ..." ; \
! 	  if [ x`(cd ${srcdir} && /bin/pwd)` = x`(/bin/pwd)` ] ; then \
! 	    tar -chf - leim-list.el quail ja-dic \
! 		| (cd ${INSTALLDIR}; umask 0; tar -xvf - && cat > /dev/null) ;\
! 	  else \
! 	    tar -chf - leim-list.el quail \
! 		| (cd ${INSTALLDIR}; umask 0; tar -xvf - && cat > /dev/null) ;\
! 	    cd ${srcdir}; \
! 	    tar -chf - quail/* ja-dic \
! 		| (cd ${INSTALLDIR}; umask 0; tar -xvf - && cat > /dev/null) ;\
! 	  fi; \
! 	  rm -rf ${INSTALLDIR}/CVS        ${INSTALLDIR}/*/CVS; \
! 	  rm -f  ${INSTALLDIR}/.cvsignore ${INSTALLDIR}/*/.cvsignore; \
! 	  rm -f  ${INSTALLDIR}/.arch-inventory ${INSTALLDIR}/*/.arch-inventory; \
! 	  rm -f  ${INSTALLDIR}/\#*        ${INSTALLDIR}/*/\#* ; \
! 	  rm -f  ${INSTALLDIR}/.\#*       ${INSTALLDIR}/*/.\#* ; \
! 	  rm -f  ${INSTALLDIR}/*~         ${INSTALLDIR}/*/*~ ; \
! 	  rm -f  ${INSTALLDIR}/*.orig     ${INSTALLDIR}/*/*.orig ; \
! 	else true; fi
  	-unset CDPATH; \
  	if [ -n "${GZIP_PROG}" ]; \
  	then \
--- 216,247 ----
  	sed -n '/^[^;]/ p' < ${srcdir}/leim-ext.el >> $@
  
  install: all
! 	if [ -d ${INSTALLDIR} ] ; then \
! 	  if [ x`(cd ${INSTALLDIR} && /bin/pwd)` != x`(/bin/pwd)` ] ; then \
  	    rm -rf ${INSTALLDIR}/leim-list.el; \
  	    rm -rf ${INSTALLDIR}/quail ${INSTALLDIR}/ja-dic ; \
! 	  fi ; \
! 	else \
! 	  ${srcdir}/${dot}${dot}/mkinstalldirs ${INSTALLDIR}; \
! 	fi; \
! 	echo "Copying leim files to ${INSTALLDIR} ..." ; \
! 	if [ x`(cd ${srcdir} && /bin/pwd)` = x`(/bin/pwd)` ] ; then \
! 	  tar -chf - leim-list.el quail ja-dic \
! 		| (cd ${INSTALLDIR}; umask 0; tar -xvf - && cat > /dev/null) ;\
! 	else \
! 	  tar -chf - leim-list.el quail \
! 		| (cd ${INSTALLDIR}; umask 0; tar -xvf - && cat > /dev/null) ;\
! 	  cd ${srcdir}; \
! 	  tar -chf - quail/* ja-dic \
! 		| (cd ${INSTALLDIR}; umask 0; tar -xvf - && cat > /dev/null) ;\
! 	fi; \
! 	rm -rf ${INSTALLDIR}/CVS        ${INSTALLDIR}/*/CVS; \
! 	rm -f  ${INSTALLDIR}/.cvsignore ${INSTALLDIR}/*/.cvsignore; \
! 	rm -f  ${INSTALLDIR}/.arch-inventory ${INSTALLDIR}/*/.arch-inventory; \
! 	rm -f  ${INSTALLDIR}/\#*        ${INSTALLDIR}/*/\#* ; \
! 	rm -f  ${INSTALLDIR}/.\#*       ${INSTALLDIR}/*/.\#* ; \
! 	rm -f  ${INSTALLDIR}/*~         ${INSTALLDIR}/*/*~ ; \
! 	rm -f  ${INSTALLDIR}/*.orig     ${INSTALLDIR}/*/*.orig
  	-unset CDPATH; \
  	if [ -n "${GZIP_PROG}" ]; \
  	then \
--- patch end ---------------------------------------------------

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] Unbreak `make install' in leim/ when leim's ${INSTALLDIR} doesn't exist
  2006-10-11 23:22 [PATCH] Unbreak `make install' in leim/ when leim's ${INSTALLDIR} doesn't exist Giorgos Keramidas
@ 2006-10-12  0:31 ` Giorgos Keramidas
  2006-10-12  5:59 ` Kenichi Handa
  1 sibling, 0 replies; 9+ messages in thread
From: Giorgos Keramidas @ 2006-10-12  0:31 UTC (permalink / raw)


On 2006-10-12 02:22, Giorgos Keramidas <keramida@ceid.upatras.gr> wrote:
> The current `make install' target of the leim/ subdirectory has a subtle
> problem when ${prefix}/share/emacs/22.0.50/leim does not exist at all.

The previous patch changes the logic of the if-then blocks.  The install
commands shouldn't run at all if ${INSTALLDIR} is the current directory.

The following version keeps the same behavior, and touches a smaller
part of the Makefile too :)

--- patch begins here -----------------------------------------------------
Unbreak `make install' in leim/ when leim's ${INSTALLDIR} doesn't exist.

What was happening with the old shell script called by the `install'
target was kind of tricky.  The command:

    if [ x`(cd ${INSTALLDIR} && /bin/pwd)` != x`(/bin/pwd)` ] ; then
      if [ -d ${INSTALLDIR} ] ; then \

contains a backquoted `cd' command into a directory which may not exist.
This causes the /bin/sh shell on Solaris (possibly other systems too),
to abort the entire if-then compound statement, because the `cd' command
fails before the if-then statement has a chance to run at all (i.e. at
backquote-expansion time).

Switching the order of the two if-then checks ensures that `cd' will
only run if ${INSTALLDIR} *really* exists, and `make install' in leim/
works again.

diff -r 34e5fff7519a -r 3495805897b2 leim/Makefile.in
*** a/leim/Makefile.in	Wed Oct 11 18:10:15 2006 +0300
--- b/leim/Makefile.in	Thu Oct 12 02:18:45 2006 +0300
***************
*** 216,228 ****
  	sed -n '/^[^;]/ p' < ${srcdir}/leim-ext.el >> $@
  
  install: all
  	if [ x`(cd ${INSTALLDIR} && /bin/pwd)` != x`(/bin/pwd)` ] ; then \
! 	  if [ -d ${INSTALLDIR} ] ; then \
! 	    rm -rf ${INSTALLDIR}/leim-list.el; \
! 	    rm -rf ${INSTALLDIR}/quail ${INSTALLDIR}/ja-dic ; \
! 	  else \
! 	    ${srcdir}/${dot}${dot}/mkinstalldirs ${INSTALLDIR}; \
! 	  fi; \
  	  echo "Copying leim files to ${INSTALLDIR} ..." ; \
  	  if [ x`(cd ${srcdir} && /bin/pwd)` = x`(/bin/pwd)` ] ; then \
  	    tar -chf - leim-list.el quail ja-dic \
--- 216,227 ----
  	sed -n '/^[^;]/ p' < ${srcdir}/leim-ext.el >> $@
  
  install: all
+ 	if [ ! -d ${INSTALLDIR} ]; then \
+ 	  ${srcdir}/${dot}${dot}/mkinstalldirs ${INSTALLDIR}; \
+ 	fi
  	if [ x`(cd ${INSTALLDIR} && /bin/pwd)` != x`(/bin/pwd)` ] ; then \
! 	  rm -rf ${INSTALLDIR}/leim-list.el; \
! 	  rm -rf ${INSTALLDIR}/quail ${INSTALLDIR}/ja-dic ; \
  	  echo "Copying leim files to ${INSTALLDIR} ..." ; \
  	  if [ x`(cd ${srcdir} && /bin/pwd)` = x`(/bin/pwd)` ] ; then \
  	    tar -chf - leim-list.el quail ja-dic \
***************
*** 241,247 ****
  	  rm -f  ${INSTALLDIR}/.\#*       ${INSTALLDIR}/*/.\#* ; \
  	  rm -f  ${INSTALLDIR}/*~         ${INSTALLDIR}/*/*~ ; \
  	  rm -f  ${INSTALLDIR}/*.orig     ${INSTALLDIR}/*/*.orig ; \
! 	else true; fi
  	-unset CDPATH; \
  	if [ -n "${GZIP_PROG}" ]; \
  	then \
--- 240,246 ----
  	  rm -f  ${INSTALLDIR}/.\#*       ${INSTALLDIR}/*/.\#* ; \
  	  rm -f  ${INSTALLDIR}/*~         ${INSTALLDIR}/*/*~ ; \
  	  rm -f  ${INSTALLDIR}/*.orig     ${INSTALLDIR}/*/*.orig ; \
! 	fi
  	-unset CDPATH; \
  	if [ -n "${GZIP_PROG}" ]; \
  	then \
--- patch ends here -------------------------------------------------------

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] Unbreak `make install' in leim/ when leim's ${INSTALLDIR} doesn't exist
  2006-10-11 23:22 [PATCH] Unbreak `make install' in leim/ when leim's ${INSTALLDIR} doesn't exist Giorgos Keramidas
  2006-10-12  0:31 ` Giorgos Keramidas
@ 2006-10-12  5:59 ` Kenichi Handa
  2006-10-12 12:35   ` Giorgos Keramidas
  1 sibling, 1 reply; 9+ messages in thread
From: Kenichi Handa @ 2006-10-12  5:59 UTC (permalink / raw)
  Cc: emacs-devel

In article <549c434ebfb50d1a4ca2.1160608974@gothmog.pc>, Giorgos Keramidas <keramida@ceid.upatras.gr> writes:

> The current `make install' target of the leim/ subdirectory has a subtle
> problem when ${prefix}/share/emacs/22.0.50/leim does not exist at all.

Oops, my last change was not sufficient.

> The following patch fixes this.

It seems that the patch removes CVS and etc. from the
current directory if it equals to INSTALLDIR.

So, I've just installed the different fix.  Could you please
try it?

---
Kenichi Handa
handa@m17n.org

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] Unbreak `make install' in leim/ when leim's ${INSTALLDIR} doesn't exist
  2006-10-12  5:59 ` Kenichi Handa
@ 2006-10-12 12:35   ` Giorgos Keramidas
  2006-10-12 12:47     ` Andreas Schwab
                       ` (2 more replies)
  0 siblings, 3 replies; 9+ messages in thread
From: Giorgos Keramidas @ 2006-10-12 12:35 UTC (permalink / raw)
  Cc: emacs-devel

On 2006-10-12 14:59, Kenichi Handa <handa@m17n.org> wrote:
> In article <549c434ebfb50d1a4ca2.1160608974@gothmog.pc>,
> Giorgos Keramidas <keramida@ceid.upatras.gr> writes:
> 
> > The current `make install' target of the leim/ subdirectory has a subtle
> > problem when ${prefix}/share/emacs/22.0.50/leim does not exist at all.
> 
> Oops, my last change was not sufficient.
> 
> > The following patch fixes this.
> 
> It seems that the patch removes CVS and etc. from the current
> directory if it equals to INSTALLDIR.

Yes, the first version of the patch I send was buggy in this way.
Sorry for not having tested it as thoroughly.

> So, I've just installed the different fix.  Could you please try it?

I just pulled the changes from CVS.

It seems to include this part:

+       if [ ! -d ${INSTALLDIR} ] ; then \
+          ${srcdir}/${dot}${dot}/mkinstalldirs ${INSTALLDIR}; \
+       else true; fi

We don't really *need* to have an else branch in all statements.  We can
write this as:

+       if [ ! -d ${INSTALLDIR} ] ; then \
+          ${srcdir}/${dot}${dot}/mkinstalldirs ${INSTALLDIR}; \
+       fi

Apart from this minor difference, this is identical to the second
version of the same patch I posted, so I'm fairly confident it works.
I will test it with a new build later today though.

Thank you for the ultra fast responses :)

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] Unbreak `make install' in leim/ when leim's ${INSTALLDIR} doesn't exist
  2006-10-12 12:35   ` Giorgos Keramidas
@ 2006-10-12 12:47     ` Andreas Schwab
  2006-10-12 13:12       ` Giorgos Keramidas
  2006-10-12 12:52     ` David Kastrup
  2006-10-12 13:10     ` Kenichi Handa
  2 siblings, 1 reply; 9+ messages in thread
From: Andreas Schwab @ 2006-10-12 12:47 UTC (permalink / raw)
  Cc: emacs-devel, Kenichi Handa

Giorgos Keramidas <keramida@ceid.upatras.gr> writes:

> It seems to include this part:
>
> +       if [ ! -d ${INSTALLDIR} ] ; then \
> +          ${srcdir}/${dot}${dot}/mkinstalldirs ${INSTALLDIR}; \
> +       else true; fi
>
> We don't really *need* to have an else branch in all statements.  We can
> write this as:
>
> +       if [ ! -d ${INSTALLDIR} ] ; then \
> +          ${srcdir}/${dot}${dot}/mkinstalldirs ${INSTALLDIR}; \
> +       fi

Except that some old shells will cause the whole command to fail if the
condition fails.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] Unbreak `make install' in leim/ when leim's ${INSTALLDIR} doesn't exist
  2006-10-12 12:35   ` Giorgos Keramidas
  2006-10-12 12:47     ` Andreas Schwab
@ 2006-10-12 12:52     ` David Kastrup
  2006-10-12 13:10     ` Kenichi Handa
  2 siblings, 0 replies; 9+ messages in thread
From: David Kastrup @ 2006-10-12 12:52 UTC (permalink / raw)
  Cc: emacs-devel, Kenichi Handa

Giorgos Keramidas <keramida@ceid.upatras.gr> writes:

> I just pulled the changes from CVS.
>
> It seems to include this part:
>
> +       if [ ! -d ${INSTALLDIR} ] ; then \
> +          ${srcdir}/${dot}${dot}/mkinstalldirs ${INSTALLDIR}; \
> +       else true; fi
>
> We don't really *need* to have an else branch in all statements.  We can
> write this as:
>
> +       if [ ! -d ${INSTALLDIR} ] ; then \
> +          ${srcdir}/${dot}${dot}/mkinstalldirs ${INSTALLDIR}; \
> +       fi

This disagrees with
(info "(autoconf) Limitations of Builtins")

    `if'
[...]
     There are shells that do not reset the exit status from an `if':

          $ if (exit 42); then true; fi; echo $?
          42

     whereas a proper shell should have printed `0'.  This is especially
     bad in Makefiles since it produces false failures.  This is why
     properly written Makefiles, such as Automake's, have such hairy
     constructs:

          if test -f "$file"; then
            install "$file" "$dest"
          else
            :
          fi


Note that you can often use `||' instead of `if', then this is not as
ugly.  Also note that `:' may actually more portable than `true'
according to the same source:

`true'
     Don't worry: as far as we know `true' is portable.  Nevertheless,
     it's not always a builtin (e.g., Bash 1.x), and the portable shell
     community tends to prefer using `:'.  This has a funny side
     effect: when asked whether `false' is more portable than `true'
     Alexandre Oliva answered:

          In a sense, yes, because if it doesn't exist, the shell will
          produce an exit status of failure, which is correct for
          `false', but not for `true'.


-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] Unbreak `make install' in leim/ when leim's ${INSTALLDIR} doesn't exist
  2006-10-12 12:35   ` Giorgos Keramidas
  2006-10-12 12:47     ` Andreas Schwab
  2006-10-12 12:52     ` David Kastrup
@ 2006-10-12 13:10     ` Kenichi Handa
  2006-10-12 13:13       ` Giorgos Keramidas
  2 siblings, 1 reply; 9+ messages in thread
From: Kenichi Handa @ 2006-10-12 13:10 UTC (permalink / raw)
  Cc: emacs-devel

In article <20061012123556.GA89997@gothmog.pc>, Giorgos Keramidas <keramida@ceid.upatras.gr> writes:

> +       if [ ! -d ${INSTALLDIR} ] ; then \
> +          ${srcdir}/${dot}${dot}/mkinstalldirs ${INSTALLDIR}; \
> +       else true; fi

Here, I just followed the coding convention of the top level
Makefile.in.

> Apart from this minor difference, this is identical to the second
> version of the same patch I posted,

It seems that I missed the second version somehow, sorry.

> I will test it with a new build later today though.

Thank you.

---
Kenichi Handa
handa@m17n.org

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] Unbreak `make install' in leim/ when leim's ${INSTALLDIR} doesn't exist
  2006-10-12 12:47     ` Andreas Schwab
@ 2006-10-12 13:12       ` Giorgos Keramidas
  0 siblings, 0 replies; 9+ messages in thread
From: Giorgos Keramidas @ 2006-10-12 13:12 UTC (permalink / raw)
  Cc: emacs-devel, Kenichi Handa

On 2006-10-12 14:47, Andreas Schwab <schwab@suse.de> wrote:
>Giorgos Keramidas <keramida@ceid.upatras.gr> writes:
>> It seems to include this part:
>>
>> +       if [ ! -d ${INSTALLDIR} ] ; then \
>> +          ${srcdir}/${dot}${dot}/mkinstalldirs ${INSTALLDIR}; \
>> +       else true; fi
>>
>> We don't really *need* to have an else branch in all statements.  We can
>> write this as:
>>
>> +       if [ ! -d ${INSTALLDIR} ] ; then \
>> +          ${srcdir}/${dot}${dot}/mkinstalldirs ${INSTALLDIR}; \
>> +       fi
> 
> Except that some old shells will cause the whole command to fail if the
> condition fails.

I see.  I didn't know about this.  Thanks for the clarification :)

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] Unbreak `make install' in leim/ when leim's ${INSTALLDIR} doesn't exist
  2006-10-12 13:10     ` Kenichi Handa
@ 2006-10-12 13:13       ` Giorgos Keramidas
  0 siblings, 0 replies; 9+ messages in thread
From: Giorgos Keramidas @ 2006-10-12 13:13 UTC (permalink / raw)
  Cc: emacs-devel

On 2006-10-12 22:10, Kenichi Handa <handa@m17n.org> wrote:
> In article <20061012123556.GA89997@gothmog.pc>, Giorgos Keramidas <keramida@ceid.upatras.gr> writes:
> 
> > +       if [ ! -d ${INSTALLDIR} ] ; then \
> > +          ${srcdir}/${dot}${dot}/mkinstalldirs ${INSTALLDIR}; \
> > +       else true; fi
> 
> Here, I just followed the coding convention of the top level
> Makefile.in.
> 
> > Apart from this minor difference, this is identical to the second
> > version of the same patch I posted,
> 
> It seems that I missed the second version somehow, sorry.
> 
> > I will test it with a new build later today though.
> 
> Thank you.

Just finished testing.  All is fine now :)

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2006-10-12 13:13 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-11 23:22 [PATCH] Unbreak `make install' in leim/ when leim's ${INSTALLDIR} doesn't exist Giorgos Keramidas
2006-10-12  0:31 ` Giorgos Keramidas
2006-10-12  5:59 ` Kenichi Handa
2006-10-12 12:35   ` Giorgos Keramidas
2006-10-12 12:47     ` Andreas Schwab
2006-10-12 13:12       ` Giorgos Keramidas
2006-10-12 12:52     ` David Kastrup
2006-10-12 13:10     ` Kenichi Handa
2006-10-12 13:13       ` Giorgos Keramidas

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).