unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Richard Stallman <rms@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: widget-button-click chokes on frame selection event
Date: Sun, 17 Sep 2006 17:04:10 -0400	[thread overview]
Message-ID: <E1GP3oA-0002kz-Tc@fencepost.gnu.org> (raw)
In-Reply-To: <87fyercx00.fsf@gate450.dyndns.org> (message from Andreas Seltenreich on Sat, 16 Sep 2006 23:38:55 +0200)

I don't know how to reproduce the problem, but I think I see what
is going wrong.  I am guessing how to fix it.  What results does
this give?

*** wid-edit.el	22 Feb 2006 13:56:50 -0500	1.166
--- wid-edit.el	17 Sep 2006 14:35:20 -0400	
***************
*** 959,973 ****
  				  (push event unread-command-events)
  				  (setq event oevent)
  				  (throw 'button-press-cancelled t))
! 				(setq pos (widget-event-point event))
! 				(if (and pos
! 					 (eq (get-char-property pos 'button)
! 					     button))
! 				    (when face
! 				      (overlay-put overlay 'face pressed-face)
! 				      (overlay-put overlay 'mouse-face pressed-face))
! 				  (overlay-put overlay 'face face)
! 				  (overlay-put overlay 'mouse-face mouse-face)))))
  
  			  ;; When mouse is released over the button, run
  			  ;; its action function.
--- 959,976 ----
  				  (push event unread-command-events)
  				  (setq event oevent)
  				  (throw 'button-press-cancelled t))
! 				(unless (or (integerp event)
! 					    (memq (car event) '(switch-frame select-window))
! 					    (eq (car event) 'scroll-bar-movement))
! 				  (setq pos (widget-event-point event))
! 				  (if (and pos
! 					   (eq (get-char-property pos 'button)
! 					       button))
! 				      (when face
! 					(overlay-put overlay 'face pressed-face)
! 					(overlay-put overlay 'mouse-face pressed-face))
! 				    (overlay-put overlay 'face face)
! 				    (overlay-put overlay 'mouse-face mouse-face))))))
  
  			  ;; When mouse is released over the button, run
  			  ;; its action function.

  reply	other threads:[~2006-09-17 21:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-16 21:38 widget-button-click chokes on frame selection event Andreas Seltenreich
2006-09-17 21:04 ` Richard Stallman [this message]
2006-09-17 21:49   ` Andreas Seltenreich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1GP3oA-0002kz-Tc@fencepost.gnu.org \
    --to=rms@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).