unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Richard Stallman <rms@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: [drew.adams@oracle.com: customizing hl-line-face should reset global-hl-line-overlay to nil]
Date: Tue, 29 Aug 2006 07:47:46 -0400	[thread overview]
Message-ID: <E1GI24I-000798-Ds@fencepost.gnu.org> (raw)
In-Reply-To: <44F2F7F0.7070205@gmx.at> (message from martin rudalics on Mon, 28 Aug 2006 16:04:32 +0200)

    > Customizing `hl-line-face' has no immediate effect. You must save the
    > customization, quit Emacs, and restart Emacs, to see the effect.

    Would the attached patch help?

How about making hl-mode check occasionally whether the value
of hl-line-face has changed since the overlay was set up?
That would be cleaner because it would not depend on the user
to use the custom mechanism.  It would work with plain setq.

    However, please see my other email about using a face instead of a user
    option (variable). Wouldn't that also take care of this problem? That is, if
    there is no face variable, and users change the face itself, then that would
    be immediately reflected in the overlay, no?

Creating a special `hl-line' face for this seems like a good idea.
For compatibility, we can preserve the existing variable
`hl-line-face', and make its initial value `hl-line'.
That way, if users have customized by setting the variable,
their customizations will not break.

  parent reply	other threads:[~2006-08-29 11:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-28  9:51 [drew.adams@oracle.com: customizing hl-line-face should reset global-hl-line-overlay to nil] Richard Stallman
2006-08-28 14:04 ` martin rudalics
2006-08-28 15:15   ` Drew Adams
2006-08-28 15:44     ` martin rudalics
2006-08-28 16:15       ` Drew Adams
2006-08-28 17:13         ` Chong Yidong
2006-08-28 18:03           ` Drew Adams
2006-08-29 11:47   ` Richard Stallman [this message]
2006-08-29 13:28     ` Chong Yidong
2006-08-29 13:42       ` [drew.adams@oracle.com: customizing hl-line-face should resetglobal-hl-line-overlay " Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1GI24I-000798-Ds@fencepost.gnu.org \
    --to=rms@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).