From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: Patch to remove minor modes in tutorial Date: Mon, 24 Jul 2006 10:42:57 -0400 Message-ID: References: <449D4787.6030809@student.lu.se> <449EFFBB.80508@student.lu.se> <449FE5AB.1080906@student.lu.se> <44A00F46.3010000@student.lu.se> <44A5C419.5090908@student.lu.se> <44A789AE.8040104@student.lu.se> <44ADA45D.8080406@student.lu.se> <44BBB6FD.1070003@student.lu.se> <44BBC9B1.8080808@student.lu.se> Reply-To: rms@gnu.org NNTP-Posting-Host: main.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: sea.gmane.org 1153752463 32543 80.91.229.2 (24 Jul 2006 14:47:43 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 24 Jul 2006 14:47:43 +0000 (UTC) Cc: lennart.borgman.073@student.lu.se, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jul 24 16:47:25 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1G51iH-000308-3s for ged-emacs-devel@m.gmane.org; Mon, 24 Jul 2006 16:47:17 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1G51iG-0002Sr-Mp for ged-emacs-devel@m.gmane.org; Mon, 24 Jul 2006 10:47:16 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1G51e8-0006SS-IU for emacs-devel@gnu.org; Mon, 24 Jul 2006 10:43:00 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1G51e6-0006Rf-VS for emacs-devel@gnu.org; Mon, 24 Jul 2006 10:42:59 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1G51e6-0006RV-Oz for emacs-devel@gnu.org; Mon, 24 Jul 2006 10:42:58 -0400 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.52) id 1G51fD-0000Mr-5A for emacs-devel@gnu.org; Mon, 24 Jul 2006 10:44:07 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34) id 1G51e5-00089z-MH; Mon, 24 Jul 2006 10:42:57 -0400 Original-To: Lennart Borgman In-reply-to: <44BBC9B1.8080808@student.lu.se> (message from Lennart Borgman on Mon, 17 Jul 2006 19:32:33 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:57547 (default-keys '( ;; These are not mentioned but are basic: (ESC-prefix [27]) (Control-X-prefix [?\C-x]) (mode-specific-command-prefix [?\C-c]) Please put that constant list into a variable instead of embedding it inside the function. (sort-keys (lambda(left right) (let ((x (append (cadr left) nil)) (y (append (cadr right) nil))) (while (and x y (equal (car x) (car y))) (setq x (cdr x)) (setq y (cdr y))) Please give this a defun and give it a doc string that explains precisely what it tests. (insert-button (car remark) 'action (lambda(b) (interactive) (let ((value (button-get b 'value))) (help--describe-nonstandard-key value))) 'value (cdr remark) 'follow-link t 'face '(:inherit link :background "yellow")) What is the purpose of presenting that button? What does it do when the user clicks on it? Comments have to say such things. In general, your code has hardly any comments. Please add comments enough to make it _clear_.