Horrible kludge in ff-get-file

Horrible kludge in ff-get-file

[Richard Stallman]

I just saw this code in ada-mode.el

  ;; Another special construct for find-file.el : when in a separate clause,
  ;; go to the correct package.
  (add-to-list 'ff-special-constructs
               (cons "^separate[ \t\n]*(\\(\\(\\sw\\|[_.]\\)+\\))"
                     (lambda ()
		       (if (fboundp 'ff-get-file)
			   (if (boundp 'fname)
			       (setq fname (ff-get-file
					    ada-search-directories-internal
					    (ada-make-filename-from-adaname
					     (match-string 1))
					    ada-spec-suffixes)))))))

This would be clean if fname were renamed to a clean meaningful name
and had a defvar.

Would someone please do that?

Re: Horrible kludge in ff-get-file

[Thien-Thi Nguyen]

Richard Stallman <rms@gnu.org> writes:

>   ;; Another special construct for find-file.el : when in a separate clause,
>   ;; go to the correct package.
>   (add-to-list 'ff-special-constructs
>                (cons "^separate[ \t\n]*(\\(\\(\\sw\\|[_.]\\)+\\))"
>                      (lambda ()
> 		       (if (fboundp 'ff-get-file)
> 			   (if (boundp 'fname)
> 			       (setq fname (ff-get-file
> 					    ada-search-directories-internal
> 					    (ada-make-filename-from-adaname
> 					     (match-string 1))
> 					    ada-spec-suffixes)))))))
> 
> This would be clean if fname were renamed to a clean meaningful name
> and had a defvar.
> 
> Would someone please do that?

there is a cleaner fix: better document `ff-special-constructs'
so that the thunk's return value is both necessary and sufficient
to do the job (no need for `setq' or knowledge of `fname').

also, the binding checks are remnants from the time before
`ff-special-constructs' was autoloaded; they can be removed.

i will make these changes shortly.

thi