From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: crash in cvs head Date: Fri, 30 Jun 2006 23:21:45 -0400 Message-ID: References: Reply-To: rms@gnu.org NNTP-Posting-Host: main.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: sea.gmane.org 1151724157 16730 80.91.229.2 (1 Jul 2006 03:22:37 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 1 Jul 2006 03:22:37 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jul 01 05:22:36 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FwW3v-0005Uw-Vr for ged-emacs-devel@m.gmane.org; Sat, 01 Jul 2006 05:22:28 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FwW3v-0004fP-Cq for ged-emacs-devel@m.gmane.org; Fri, 30 Jun 2006 23:22:27 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FwW3H-0004Lq-5B for emacs-devel@gnu.org; Fri, 30 Jun 2006 23:21:47 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FwW3G-0004LV-KN for emacs-devel@gnu.org; Fri, 30 Jun 2006 23:21:46 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FwW3G-0004LO-B1 for emacs-devel@gnu.org; Fri, 30 Jun 2006 23:21:46 -0400 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FwWGB-0004ce-0i for emacs-devel@gnu.org; Fri, 30 Jun 2006 23:35:07 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34) id 1FwW3F-0004EE-En; Fri, 30 Jun 2006 23:21:45 -0400 Original-To: sds@podval.org In-reply-to: (message from Sam Steingold on Thu, 29 Jun 2006 11:03:23 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:56341 Archived-At: (gdb) p dpyinfo $1 = (struct x_display_info *) 0x0 (gdb) up #1 0x080cedf4 in unwind_create_frame (frame=193660300) at xfns.c:2968 2968 x_free_frame_resources (f); (gdb) p f No symbol "f" in current context. The variable f was apparently optimized away. It was surely created from FRAME. If you had examined the data inside FRAME, you could have diagnosed more. Nonetheless, I think I see the problem. Does this fix it? *** xfns.c 25 Jun 2006 12:16:32 -0400 1.668 --- xfns.c 30 Jun 2006 15:46:37 -0400 *************** *** 3075,3081 **** f->output_data.x->scroll_bar_top_shadow_pixel = -1; f->output_data.x->scroll_bar_bottom_shadow_pixel = -1; #endif /* USE_TOOLKIT_SCROLL_BARS */ - record_unwind_protect (unwind_create_frame, frame); f->icon_name = x_get_arg (dpyinfo, parms, Qicon_name, "iconName", "Title", --- 3075,3080 ---- *************** *** 3084,3089 **** --- 3083,3091 ---- f->icon_name = Qnil; FRAME_X_DISPLAY_INFO (f) = dpyinfo; + + /* With FRAME_X_DISPLAY_INFO set up, this unwind-protect is safe. */ + record_unwind_protect (unwind_create_frame, frame); #if GLYPH_DEBUG image_cache_refcount = FRAME_X_IMAGE_CACHE (f)->refcount; dpyinfo_refcount = dpyinfo->reference_count;