unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Richard Stallman <rms@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: text_property_stickiness
Date: Sun, 25 Jun 2006 11:33:48 -0400	[thread overview]
Message-ID: <E1FuWcO-0001dY-TN@fencepost.gnu.org> (raw)
In-Reply-To: <87r71ee1uq.fsf@stupidchicken.com> (message from Chong Yidong on Sat, 24 Jun 2006 16:27:09 -0400)

    *** emacs/src/textprop.c.~1.147.~	2006-05-17 13:33:46.000000000 -0400
    --- emacs/src/textprop.c	2006-06-24 16:24:46.000000000 -0400
    ***************
    *** 1787,1792 ****
    --- 1787,1794 ----
	    /* PROP is rear-non-sticky.  */
	    is_rear_sticky = 0;
	  }
    +   else
    +     return 0;

This would make text_property_stickiness return 0 when POS is before
BEGV.  Does that give correct results in calls from find_field?  I
doubt it.

Meanwhile, if POS is after ZV, Fget_text_property will get an error
in the following code, right?

	/* Consider following character.  */
	front_sticky = Fget_text_property (pos, Qfront_sticky, buffer);

This problem really is tricky, for the reasons I explained.
It could be that we need to make sure find_field is never called
for positions outside BEGV..ZV.  That may require changes in callers
at higher level, and changes in the specs of the field functions.

  reply	other threads:[~2006-06-25 15:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-24 20:27 text_property_stickiness Chong Yidong
2006-06-25 15:33 ` Richard Stallman [this message]
2006-06-25 20:59   ` text_property_stickiness Chong Yidong
2006-06-26  4:33     ` text_property_stickiness Miles Bader
2006-06-26 17:50       ` text_property_stickiness Chong Yidong
2006-06-27  2:03         ` text_property_stickiness Miles Bader
2006-06-27 16:16           ` text_property_stickiness Richard Stallman
2006-06-28  0:04             ` text_property_stickiness Chong Yidong
2006-06-29 12:59               ` text_property_stickiness Richard Stallman
2006-06-27 10:34       ` text_property_stickiness Richard Stallman
2006-06-26 11:33     ` text_property_stickiness Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1FuWcO-0001dY-TN@fencepost.gnu.org \
    --to=rms@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).