From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: asm-mode patch to allow per-file comment character setting from file locals Date: Tue, 13 Jun 2006 19:20:44 -0400 Message-ID: References: <2E2BAEFF-FEAD-4616-87CD-3B77D2734256@alastairs-place.net> <20060613.211940.19660215.jet@gyve.org> Reply-To: rms@gnu.org NNTP-Posting-Host: main.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: sea.gmane.org 1150240903 392 80.91.229.2 (13 Jun 2006 23:21:43 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 13 Jun 2006 23:21:43 +0000 (UTC) Cc: alastair@alastairs-place.net, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jun 14 01:21:41 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FqICa-0006Z5-8i for ged-emacs-devel@m.gmane.org; Wed, 14 Jun 2006 01:21:40 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FqICZ-0006ES-Nd for ged-emacs-devel@m.gmane.org; Tue, 13 Jun 2006 19:21:39 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FqIBi-0005YZ-QF for emacs-devel@gnu.org; Tue, 13 Jun 2006 19:20:46 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FqIBi-0005Xa-5K for emacs-devel@gnu.org; Tue, 13 Jun 2006 19:20:46 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FqIBh-0005XV-UK for emacs-devel@gnu.org; Tue, 13 Jun 2006 19:20:45 -0400 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FqIKk-0003yp-Nm for emacs-devel@gnu.org; Tue, 13 Jun 2006 19:30:06 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34) id 1FqIBg-0002Sl-V5; Tue, 13 Jun 2006 19:20:45 -0400 Original-To: Masatake YAMATO In-reply-to: <20060613.211940.19660215.jet@gyve.org> (message from Masatake YAMATO on Tue, 13 Jun 2006 21:19:40 +0900 (JST)) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:55875 Archived-At: When you have a construct such as gas-register-machine-dependent that generates a defun, it should be a macro, not a function. The macro name should start with `def'. And the name of the function it defines should not be constructed like this (let ((mode-func (intern (format "gas-%s-mode" name)))) Instead, the name of the function should appear as the first argument of the macro. Those are general principles for Lisp programming which ought to be applied here. Comparing the usefulness for editing of these two proposed extensions to asm mode is a different question. It would be useful for those who are interested in such things to compare them and state their opinions.