From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: [bug] read-passwd of CVS Emacs Date: Wed, 24 May 2006 20:37:05 -0400 Message-ID: References: <20060524.123750.178780620.kazu@iij.ad.jp> Reply-To: rms@gnu.org NNTP-Posting-Host: main.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: sea.gmane.org 1148517538 18082 80.91.229.2 (25 May 2006 00:38:58 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 25 May 2006 00:38:58 +0000 (UTC) Cc: "Kazu Yamamoto \(=?iso-2022-jp?B?GyRCOzNLXE9CSScbKEI=?=\)" , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 25 02:38:55 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Fj3sI-0006nU-Q3 for ged-emacs-devel@m.gmane.org; Thu, 25 May 2006 02:38:51 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Fj3sI-0003gL-5U for ged-emacs-devel@m.gmane.org; Wed, 24 May 2006 20:38:50 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Fj3qd-0002oY-3Y for emacs-devel@gnu.org; Wed, 24 May 2006 20:37:07 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Fj3qc-0002oD-Ia for emacs-devel@gnu.org; Wed, 24 May 2006 20:37:06 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Fj3qc-0002o7-DU for emacs-devel@gnu.org; Wed, 24 May 2006 20:37:06 -0400 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.52) id 1Fj3vA-0005bW-NO for emacs-devel@gnu.org; Wed, 24 May 2006 20:41:48 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34) id 1Fj3qb-0000M3-86; Wed, 24 May 2006 20:37:05 -0400 Original-To: Kevin Rodgers In-reply-to: (message from Kevin Rodgers on Wed, 24 May 2006 10:08:46 -0600) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:55236 Archived-At: The error is "Attempt to modify read-only object" and is somehow caused by a string indexing bug. Here's a patch: There is no indexing bug. The bug is that it modifies the string that was passed in by the caller. This seems to fix it for me. But I see that you proposed another change, putting various other properties on the prompt. Is that still necessary, when this is done? I think it won't be needed, because this prompt doesn't go in the minibuffer, so you can't move point over it or insert other text after it. Index: subr.el =================================================================== RCS file: /cvsroot/emacs/emacs/lisp/subr.el,v retrieving revision 1.511 diff -c -c -r1.511 subr.el *** subr.el 24 May 2006 13:22:12 -0000 1.511 --- subr.el 24 May 2006 22:06:17 -0000 *************** *** 1637,1642 **** --- 1637,1645 ---- (sit-for 1)))) success) (let ((pass nil) + ;; Copy it so that add-text-properties won't modify + ;; the object that was passed in by the caller. + (prompt (copy-sequence prompt)) (c 0) (echo-keystrokes 0) (cursor-in-echo-area t)