From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: query-replace in isearch (was Re: should search ring contain duplicates?) Date: Tue, 23 May 2006 22:18:32 -0400 Message-ID: References: <200605030727.k437R2Wx009975@amrm2.ics.uci.edu> <87bqufwbls.fsf@jurta.org> <200605031504.k43F49hr001544@scanner2.ics.uci.edu> <87wtcslqoj.fsf@jurta.org> <87slng8c5p.fsf@jurta.org> <87ac9ekbw6.fsf@jurta.org> <878xotibsd.fsf@jurta.org> Reply-To: rms@gnu.org NNTP-Posting-Host: main.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: sea.gmane.org 1148437220 10651 80.91.229.2 (24 May 2006 02:20:20 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 24 May 2006 02:20:20 +0000 (UTC) Cc: dann@ics.uci.edu, emacs-devel@gnu.org, storm@cua.dk Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 24 04:20:17 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Fiiyp-0006VQ-ML for ged-emacs-devel@m.gmane.org; Wed, 24 May 2006 04:20:11 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Fiiyp-0005WW-0r for ged-emacs-devel@m.gmane.org; Tue, 23 May 2006 22:20:11 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FiixG-0004vY-Nh for emacs-devel@gnu.org; Tue, 23 May 2006 22:18:34 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FiixF-0004vB-Ut for emacs-devel@gnu.org; Tue, 23 May 2006 22:18:34 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FiixF-0004v4-Om for emacs-devel@gnu.org; Tue, 23 May 2006 22:18:33 -0400 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.52) id 1Fij1b-0006JO-4Y for emacs-devel@gnu.org; Tue, 23 May 2006 22:23:03 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34) id 1FiixE-0006VI-UM; Tue, 23 May 2006 22:18:33 -0400 Original-To: Juri Linkov In-reply-to: <878xotibsd.fsf@jurta.org> (message from Juri Linkov on Tue, 23 May 2006 08:17:03 +0300) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:55171 Archived-At: This solution has a significant drawback: this argument is available only to one reading function `read-from-minibuffer' and is not available to all other minibuffer reading functions (like `read-file-name' etc.). Adding this argument to every reading function would be a clumsy solution. That is a good point. I'm really inclined to bind a global variable `history-length' to a special value before calling a reading function (and to access this value in `read_minibuf' where all reading functions eventually go). I agree that a global variable seems like a good solution, but calling it `history-length' seems counterintuitive. I suggest calling it `history-dont-add'. Would you like to implement this? Meanwhile, would you please install the previous patch to delete KEEP_ALL, aside from the parts that change the behavior of command-history, as I said before?