From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kenichi Handa Newsgroups: gmane.emacs.devel Subject: Re: Problem report #13 FALSE Date: Thu, 11 May 2006 11:19:00 +0900 Message-ID: References: <200604111549.k3BFnQ2N015126@scanner2.ics.uci.edu> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.3 - "Ushinoya") Content-Type: text/plain; charset=US-ASCII X-Trace: sea.gmane.org 1147314001 30165 80.91.229.2 (11 May 2006 02:20:01 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 11 May 2006 02:20:01 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 11 04:19:55 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Fe0mN-0007hI-7m for ged-emacs-devel@m.gmane.org; Thu, 11 May 2006 04:19:55 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Fe0mM-0002s8-LK for ged-emacs-devel@m.gmane.org; Wed, 10 May 2006 22:19:50 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Fe0mA-0002qo-EV for emacs-devel@gnu.org; Wed, 10 May 2006 22:19:38 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Fe0m9-0002pE-7O for emacs-devel@gnu.org; Wed, 10 May 2006 22:19:38 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Fe0m9-0002p5-4H for emacs-devel@gnu.org; Wed, 10 May 2006 22:19:37 -0400 Original-Received: from [192.47.44.130] (helo=tsukuba.m17n.org) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1Fe0nY-0002hE-Fn for emacs-devel@gnu.org; Wed, 10 May 2006 22:21:04 -0400 Original-Received: from nfs.m17n.org (nfs.m17n.org [192.47.44.7]) by tsukuba.m17n.org (8.13.4/8.13.4/Debian-3sarge1) with ESMTP id k4B2JYlw022434 for ; Thu, 11 May 2006 11:19:34 +0900 Original-Received: from etlken (etlken.m17n.org [192.47.44.125]) by nfs.m17n.org (8.13.4/8.13.4/Debian-3sarge1) with ESMTP id k4B2JYr2007500 for ; Thu, 11 May 2006 11:19:34 +0900 Original-Received: from handa by etlken with local (Exim 3.36 #1 (Debian)) id 1Fe0lY-0002QP-00 for ; Thu, 11 May 2006 11:19:00 +0900 Original-To: emacs-devel@gnu.org In-reply-to: <200604111549.k3BFnQ2N015126@scanner2.ics.uci.edu> (message from Dan Nicolaescu on Tue, 11 Apr 2006 08:49:26 -0700) User-Agent: SEMI/1.14.3 (Ushinoya) FLIM/1.14.2 (Yagi-Nishiguchi) APEL/10.2 Emacs/22.0.50 (i686-pc-linux-gnu) MULE/5.0 (SAKAKI) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:54218 Archived-At: Dan Nicolaescu writes: > CID: 13 > Checker: FORWARD_NULL (help) > File: emacs/src/coding.c > Function: encode_coding_string > Description: Variable "(coding)->cmp_data" tracked as NULL was passed to a function that dereferences it. I see no bug here. A member of (coding)->cmp_data is accessed only after checking (coding)->cmp_data is not NULL. > Event var_compare_op: Added "(coding)->cmp_data" due to comparison "(coding)->cmp_data == 0" > Also see events: [var_deref_model] > At conditional (1): "(coding)->cmp_data == 0" taking true path > 6435 if (coding->type != coding_type_ccl > 6436 && (! coding->cmp_data || coding->cmp_data->used == 0)) > 6437 { Does the checker require it to be writen as below? > 6436 && (coding->cmp_data ? coding->cmp_data->used == 0 : 1)) --- Kenichi Handa handa@m17n.org