unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Kenichi Handa <handa@m17n.org>
Subject: Re: Problem report #13 FALSE
Date: Thu, 11 May 2006 11:19:00 +0900	[thread overview]
Message-ID: <E1Fe0lY-0002QP-00@etlken> (raw)
In-Reply-To: <200604111549.k3BFnQ2N015126@scanner2.ics.uci.edu> (message from Dan Nicolaescu on Tue, 11 Apr 2006 08:49:26 -0700)

Dan Nicolaescu <dann@ics.uci.edu> writes:

> CID: 13
> Checker: FORWARD_NULL (help)
> File: emacs/src/coding.c
> Function: encode_coding_string
> Description: Variable "(coding)->cmp_data" tracked as NULL was passed to a function that dereferences it.

I see no bug here.   A member of (coding)->cmp_data is
accessed only after checking (coding)->cmp_data is not NULL.

> Event var_compare_op: Added "(coding)->cmp_data" due to comparison "(coding)->cmp_data == 0"
> Also see events: [var_deref_model]
> At conditional (1): "(coding)->cmp_data == 0" taking true path

> 6435 	  if (coding->type != coding_type_ccl
> 6436 	      && (! coding->cmp_data || coding->cmp_data->used == 0))
> 6437 	    {

Does the checker require it to be writen as below?

> 6436 	      && (coding->cmp_data ? coding->cmp_data->used == 0 : 1))

---
Kenichi Handa
handa@m17n.org

  reply	other threads:[~2006-05-11  2:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-11 15:49 Problem report #13 Dan Nicolaescu
2006-05-11  2:19 ` Kenichi Handa [this message]
2006-05-11  2:46   ` Problem report #13 FALSE Dan Nicolaescu
2006-05-11  9:30   ` Andreas Schwab
2006-05-11 10:58     ` Kenichi Handa
2006-05-11  9:40   ` Jason Rumney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1Fe0lY-0002QP-00@etlken \
    --to=handa@m17n.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).